Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify autoupdate language #1774

Merged
merged 2 commits into from
Sep 14, 2023
Merged

Clarify autoupdate language #1774

merged 2 commits into from
Sep 14, 2023

Conversation

leblowl
Copy link
Contributor

@leblowl leblowl commented Sep 8, 2023

When a new update is available, it is applied automatically on restart. The update modal now let's you know that an update is available and allows you to restart now or later.

Fixes #1540

Pull Request Checklist

  • I have linked this PR to related GitHub issue.
  • I have updated the CHANGELOG.md file with relevant changes (the file is located at the root of monorepo).

@leblowl leblowl mentioned this pull request Sep 8, 2023
2 tasks
@leblowl leblowl requested a review from vinkabuki September 8, 2023 19:02
@leblowl leblowl force-pushed the pr-fix-update-modal-text branch 2 times, most recently from 2f36a15 to 9e55d63 Compare September 12, 2023 14:11
@siepra
Copy link
Contributor

siepra commented Sep 13, 2023

I'd be great if you included a screenshot of the updated component.
Also, do we have a story for this modal? I cannot see it's base on Chromatic. If it's missing, then I think it's a good moment to create one.

@leblowl
Copy link
Contributor Author

leblowl commented Sep 13, 2023

Thanks for the review! I agree, I'll add a story first. That should satisfy the screenshot request right? Or are you thinking to upload a screenshot in addition to the story?

@siepra
Copy link
Contributor

siepra commented Sep 14, 2023

I accepted the baseline 👍 Usually we post screenshots/videos in the comments section of the task

Lucas Leblow added 2 commits September 14, 2023 11:58
When a new update is available, it is applied automatically on
restart. The update modal now let's you know that an update is
available and allows you to restart now or later.

Fixes #1540
@leblowl leblowl force-pushed the pr-fix-update-modal-text branch from 2b76e0e to 361bbcf Compare September 14, 2023 17:59
@leblowl leblowl merged commit 0accb70 into develop Sep 14, 2023
@siepra siepra deleted the pr-fix-update-modal-text branch September 19, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify autoupdate language
3 participants