Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove registration attempts selector #1768

Merged
merged 8 commits into from
Oct 16, 2023
Merged

Remove registration attempts selector #1768

merged 8 commits into from
Oct 16, 2023

Conversation

vinkabuki
Copy link
Contributor

@vinkabuki vinkabuki commented Sep 7, 2023 •
edited
Loading

Pull Request Checklist

  • I have linked this PR to related GitHub issue.
  • I have updated the CHANGELOG.md file with relevant changes (the file is located at the root of monorepo).

@leblowl
Copy link
Collaborator

leblowl commented Sep 11, 2023

Looks good to me, I am curious, why are we removing the registration attempts?

@vinkabuki
Copy link
Contributor Author

image

leblowl
leblowl approved these changes Oct 4, 2023
View reviewed changes
Copy link
Collaborator

@leblowl leblowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@leblowl
Copy link
Collaborator

leblowl commented Oct 11, 2023

Just a reminder that I think squashing would be helpful

@vinkabuki vinkabuki merged commit 7f7ebab into develop Oct 16, 2023
17 of 18 checks passed
@kingalg
Copy link
Collaborator

kingalg commented Oct 30, 2023

[email protected]

I can't check it but as per discussion with @vinkabuki he confirmed that it's done.

@siepra siepra deleted the chore/remove-registration-attempts-selector branch December 8, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leblowl leblowl leblowl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Quiet
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vinkabuki @leblowl @kingalg