Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved support for nvm #1729

Merged
merged 2 commits into from
Sep 11, 2023
Merged

Improved support for nvm #1729

merged 2 commits into from
Sep 11, 2023

Conversation

UlisesGascon
Copy link
Contributor

@UlisesGascon UlisesGascon commented Aug 22, 2023 •
edited
Loading

Main Changes

  • Added .nvmrc file with the current node version, this enable the option to use directly nvm use to set the node version to the correct one (812b7db)
  • Updated the documentation accordingly (405ce12)

Changelog

@UlisesGascon UlisesGascon marked this pull request as ready for review August 22, 2023 22:56
@holmesworcester
Copy link
Contributor

holmesworcester commented Aug 23, 2023 •
edited
Loading

@UlisesGascon Thanks! It's awful when new people to the project get caught by failing to match the Node version. This is great!

@EmiM EmiM merged commit 225e264 into TryQuiet:develop Sep 11, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EmiM EmiM EmiM approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@UlisesGascon @holmesworcester @EmiM