Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User should be able to add a custom profile image #615

Closed
holmesworcester opened this issue Jun 15, 2022 · 4 comments
Closed

User should be able to add a custom profile image #615

holmesworcester opened this issue Jun 15, 2022 · 4 comments
Assignees

Comments

@holmesworcester
Copy link
Contributor

holmesworcester commented Jun 15, 2022

Being able to have custom profile images will make things way more comfortable and fun, and it will make the the conversation view in Quiet look a lot better too.

Requirements:

  1. Users should be able to add a profile image
  2. Users should be able to change their profile image
  3. Both registered and unregistered users should be able to add and change their profile image
  4. No one should be able to update the profile image for another user (we should check that profile image changes are signed with the user's message-signing key)
  5. Profile images should be visible on desktop and mobile

Nice-to-have (break out into separate issues if not done in this round of work:)

  1. Mobile user should be able to add profile image
  2. Desktop (and mobile) users should be able to crop profile images

When we release this we have to prioritize #614 so that people can't register the name Quiet, set their profile image to the Quiet logo, and spoof system messages.

@holmesworcester
Copy link
Contributor Author

We'll use whatever libraries are convenient for cropping, so we just need where this displays, and how it appears in onboarding. (What's the best way to encourage using a profile photo?)

Do Discord and Slack make it easy to pick an avatar from a list, if you don't want to add a photo?

@jgaylor
Copy link
Collaborator

jgaylor commented May 19, 2023

Figma and Loom

@holmesworcester
Copy link
Contributor Author

This is great. And we'll use whatever the library offers for cropping, e.g.

@holmesworcester holmesworcester moved this from Backlog - Desktop & Backend to Sprint 2 in Quiet Aug 18, 2023
@holmesworcester holmesworcester moved this from Sprint 2 to Backlog - Desktop & Backend in Quiet Aug 18, 2023
@leblowl leblowl self-assigned this Sep 6, 2023
@leblowl leblowl moved this from Backlog - Desktop & Backend to In progress in Quiet Sep 14, 2023
@leblowl leblowl mentioned this issue Oct 5, 2023
4 tasks
leblowl pushed a commit that referenced this issue Oct 11, 2023
On the frontend, the user profile sidebar panel simply shows the current user's
name and profile photo. Clicking on the profile photo brings up a context menu
that shows the profile and profile actions (only 'edit profile' for now).
Clicking the 'edit profile' action changes the context menu view such that you
can edit the profile photo. This commit also adds user profile photos to channel
messages. A jdenticon is showed in place of user profile photo if it doesn't
exist.

On the backend, there is a new shared orbitdb user profiles key/value store. The
key/value store maps user public keys with profiles. It uses a custom index so
that we can filter invalid entries thoroughly. In state-manager, a new
saveUserProfile saga is added which signs the profile data and sends it to the
backend.
@leblowl leblowl moved this from In progress to Waiting for review in Quiet Oct 11, 2023
@siepra siepra moved this from Waiting for review to In progress in Quiet Nov 16, 2023
@siepra siepra added the 2.1.x label Dec 7, 2023
@siepra siepra removed 2.1.x labels Jan 11, 2024
@leblowl leblowl moved this from In progress to Merged in Quiet Jan 25, 2024
@siepra siepra moved this from Merged to Ready for QA in Quiet Jan 26, 2024
@kingalg
Copy link
Collaborator

kingalg commented Feb 1, 2024

[email protected]

It's working. I feel it's more like a draft of a feature than a real feature, and changing things listed in #2251 would certainly help. But there is no reason to keep this issue open as its requirements have been fulfilled.

@kingalg kingalg closed this as completed Feb 1, 2024
@kingalg kingalg moved this from Ready for QA to Done in Quiet Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

5 participants