Skip to content
This repository has been archived by the owner on Jan 7, 2022. It is now read-only.

Restarting waggle on F5 reload #488

Merged
merged 8 commits into from
Dec 14, 2021
Merged

Restarting waggle on F5 reload #488

merged 8 commits into from
Dec 14, 2021

Conversation

siepra
Copy link
Contributor

@siepra siepra commented Dec 10, 2021

No description provided.

@siepra siepra marked this pull request as ready for review December 13, 2021 13:39
@siepra siepra requested review from vinkabuki and holmesworcester and removed request for holmesworcester December 13, 2021 13:39
@siepra siepra requested a review from EmiM December 13, 2021 13:43
Copy link
Contributor

@holmesworcester holmesworcester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there enough tests to ensure this works?

@siepra
Copy link
Contributor Author

siepra commented Dec 13, 2021

Of course! We have all the already existing tests that does great job, ensuring us that there are no regressions when we develop architectural fixes like this one

@siepra siepra merged commit 4d4bbef into develop Dec 14, 2021
@siepra siepra deleted the fix/reloading-app branch December 14, 2021 13:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants