Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix segfaults #1368

Merged
merged 4 commits into from
Sep 6, 2020
Merged

Fix segfaults #1368

merged 4 commits into from
Sep 6, 2020

Commits on Aug 5, 2020

  1. Ensure JavaScript exceptions bubble up

    @mohd-akram
    mohd-akram committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    80dda9a View commit details
    Browse the repository at this point in the history

  2. Fix segfault

    @mohd-akram
    mohd-akram committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    cf0c33f View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2020

  1. Fix mutex segfault

    @mohd-akram
    mohd-akram committed Aug 6, 2020
    Configuration menu
    Copy the full SHA
    2e561e6 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2020

  1. Fix segfault caused by memory leak 

    If the database was being closed, and non-exclusive work was scheduled,
it overrode the lock flag such that the state became open=false locked=false
instead of open=false locked=true. This caused queued work to not be
processed, leaking memory, which causes a segfault during napi cleanup.

Make the same changes to other methods for safe measure.
    @mohd-akram
    mohd-akram committed Aug 10, 2020
    Configuration menu
    Copy the full SHA
    6c2616c View commit details
    Browse the repository at this point in the history