Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use request lib in xmlrpc #9333

Merged
merged 1 commit into from
Dec 15, 2017
Merged

Use request lib in xmlrpc #9333

merged 1 commit into from
Dec 15, 2017

Conversation

kirrg001
Copy link
Contributor

@kirrg001 kirrg001 commented Dec 13, 2017

refs #9178, refs #8980

I am not really sure how to test that. @AileenCGN Any idea?

@kirrg001 kirrg001 force-pushed the xmlrpc-use-got branch 3 times, most recently from 3018efa to dff67ad Compare December 13, 2017 22:38
@aileen
Copy link
Member

aileen commented Dec 14, 2017

I don't know how to test this manually either, @kirrg001...

@kirrg001
Copy link
Contributor Author

@ErisDS Any idea how to test the change?

@aileen
Copy link
Member

aileen commented Dec 14, 2017

@kirrg001 Can you rebase this pretty please? I will check it again tomorrow and would like to merge it then, once I figured a good way to test it.

Verified

This commit was signed with the committer’s verified signature.
elliottower Elliot Tower
@kirrg001
Copy link
Contributor Author

did 👍

@aileen
Copy link
Member

aileen commented Dec 15, 2017

@kirrg001 I tested this whilst logging the response body and the refactoring to use got seems to work fine. 👍

Nevertheless, I received this message: server error. requested method weblogUpdate.ping does not exist. from trying to ping the Ping-O-Matic service. Unfortunately, I couldn't find any official docs/announcements, but seeing this seems to say, that this service doesn't exist anymore.

Maybe someone else knows about it? If not, I'd suggest that we remove the service?

@aileen
Copy link
Member

aileen commented Dec 15, 2017

Catching up on my last statement, we found the original issue with this comment:

#2148 (comment)

Ping-O-Matic doesn't bother returning a confirmation - so I have no idea if that service still works (or if my request is broken)

So maybe it's always been like this. Do you have any information regarding this, @halfdan?

If not, I suggest we keep it in there for now. We can always open a new PR to delete it, if it turns out that it definitely doesn't work anymore.

@kirrg001
Copy link
Contributor Author

@AileenCGN agree

@aileen aileen merged commit a5af7d6 into TryGhost:master Dec 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants