Bump knex-migrator to version 3.1.1 #9199

kirrg001 · 2017-11-01T22:32:48Z

no issue

Hold. I don't want to break everything, it's a sensitive update. So i'll let my brain a little time over the weekend and see if i can discover any problems e.g. breaking changes with CLI, Global Installations, Ghost...

kirrg001 · 2017-11-07T23:29:38Z

I'll try to find any problems till the next release on Thursday. e.g. what happens if your global installation is on 2.x. Furthermore, the CLI needs to be updated as well and released. Have to manage and test a couple of things before merging this. It's a sensitive change.

kirrg001 · 2017-11-10T17:00:26Z

This is on hold till we release a new CLI version including the removal of it's knex-migrator dependency and a migration command for the renewal of ssl certificates. Both will hopefully ensure that people will update to the latest CLI version and then we can merge this breaking change.

no issue - adapt major changes - adapt migration scripts - make the scripts easier - ensure rollback of fixtures works [ci skip]

- too dangerous

kirrg001 · 2017-12-04T18:50:04Z

First test succeeded. Tested with SQlite3 and MySQL.

CLI 1.2.1
Ghost 1.5.0

ghost update --zip 1.18.3

Has thrown an error, which is documented here.
Rolling back to 1.5.0 with ghost update --rollback works as expected. After upgrading the CLI to the latest and re-running ghost update --zip 1.18.3, the blog successfully migrated from 1.5.0 to 1.18.3.

kirrg001 · 2017-12-04T19:02:49Z

Second test succeeded.

Install a new blog with CLI > 1.3.0 and this PR.
Install a blog on 1.6.0 with CLI > 1.3.0 and then migrate to this PR.

aemonge · 2018-03-05T17:40:35Z

The latest version of knex-migrator 3.1.3 doesn't work.

Please update the documentation to install the 3.1.1 which works ;)

kirrg001 · 2018-03-05T17:49:08Z

@aemonge What doesn't work?

aemonge · 2018-03-06T09:20:08Z

This is the error that I've fixed changing the version of knex-migrator:
(for both cases I did a fresh install rm -rf node_modules; npm i before each attempt. Also the knex package is locally installed)

 ⚙ aemonge@osboxes  ~/usr/tmp/ghost  knex-migrator --version
3.1.4
 ⚙ aemonge@osboxes  ~/usr/tmp/ghost  knex-migrator init --mgpath node_modules/ghost
[2018-03-06 09:14:58] INFO Creating table: posts
[2018-03-06 09:14:58] INFO Creating table: users
[2018-03-06 09:14:58] INFO Creating table: roles
[2018-03-06 09:14:58] INFO Creating table: roles_users
[2018-03-06 09:14:58] INFO Creating table: permissions
[2018-03-06 09:14:58] INFO Creating table: permissions_users
[2018-03-06 09:14:58] INFO Creating table: permissions_roles
[2018-03-06 09:14:58] INFO Creating table: permissions_apps
[2018-03-06 09:14:58] INFO Creating table: settings
[2018-03-06 09:14:58] INFO Creating table: tags
[2018-03-06 09:14:58] INFO Creating table: posts_tags
[2018-03-06 09:14:58] INFO Creating table: apps
[2018-03-06 09:14:58] INFO Creating table: app_settings
[2018-03-06 09:14:58] INFO Creating table: app_fields
[2018-03-06 09:14:58] INFO Creating table: clients
[2018-03-06 09:14:58] INFO Creating table: client_trusted_domains
[2018-03-06 09:14:58] INFO Creating table: accesstokens
[2018-03-06 09:14:58] INFO Creating table: refreshtokens
[2018-03-06 09:14:58] INFO Creating table: subscribers
[2018-03-06 09:14:58] INFO Creating table: invites
[2018-03-06 09:14:58] INFO Creating table: brute
[2018-03-06 09:14:58] INFO Creating table: webhooks
[2018-03-06 09:14:58] INFO Model: Post
[2018-03-06 09:14:58] ERROR

NAME: MigrationScriptError
MESSAGE: this.builder.queryContext is not a function

level:normal

Error occurred while executing the following migration: 2-create-fixtures.js
MigrationScriptError: this.builder.queryContext is not a function
    at MigrationScriptError.KnexMigrateError (/home/aemonge/usr/tmp/ghost/node_modules/knex-migrator/lib/errors.js:9:26)
    at new MigrationScriptError (/home/aemonge/usr/tmp/ghost/node_modules/knex-migrator/lib/errors.js:28:26)
    at /home/aemonge/usr/tmp/ghost/node_modules/knex-migrator/lib/index.js:586:19
    at tryCatcher (/home/aemonge/usr/tmp/ghost/node_modules/bluebird/js/release/util.js:16:23)
    at Promise._settlePromiseFromHandler (/home/aemonge/usr/tmp/ghost/node_modules/bluebird/js/release/promise.js:512:31)
    at Promise._settlePromise (/home/aemonge/usr/tmp/ghost/node_modules/bluebird/js/release/promise.js:569:18)
    at Promise._settlePromise0 (/home/aemonge/usr/tmp/ghost/node_modules/bluebird/js/release/promise.js:614:10)
    at Promise._settlePromises (/home/aemonge/usr/tmp/ghost/node_modules/bluebird/js/release/promise.js:689:18)
    at Async._drainQueue (/home/aemonge/usr/tmp/ghost/node_modules/bluebird/js/release/async.js:133:16)
    at Async._drainQueues (/home/aemonge/usr/tmp/ghost/node_modules/bluebird/js/release/async.js:143:10)
    at Immediate.Async.drainQueues [as _onImmediate] (/home/aemonge/usr/tmp/ghost/node_modules/bluebird/js/release/async.js:17:14)
    at runCallback (timers.js:763:18)
    at tryOnImmediate (timers.js:734:5)
    at processImmediate (timers.js:716:5)

TypeError: this.builder.queryContext is not a function
    at Formatter.wrapAsIdentifier (/home/aemonge/usr/tmp/ghost/node_modules/knex/lib/formatter.js:147:37)
    at Formatter.wrapString (/home/aemonge/usr/tmp/ghost/node_modules/knex/lib/formatter.js:246:27)
    at Formatter.wrap (/home/aemonge/usr/tmp/ghost/node_modules/knex/lib/formatter.js:142:21)
    at Formatter.wrapString (/home/aemonge/usr/tmp/ghost/node_modules/knex/lib/formatter.js:244:27)
    at Formatter.wrap (/home/aemonge/usr/tmp/ghost/node_modules/knex/lib/formatter.js:142:21)
    at Formatter.columnize (/home/aemonge/usr/tmp/ghost/node_modules/knex/lib/formatter.js:57:19)
    at QueryCompiler_SQLite3.columns (/home/aemonge/usr/tmp/ghost/node_modules/knex/lib/query/compiler.js:247:35)
    at /home/aemonge/usr/tmp/ghost/node_modules/knex/lib/query/compiler.js:167:31
    at Array.map (<anonymous>)
    at QueryCompiler_SQLite3.select (/home/aemonge/usr/tmp/ghost/node_modules/knex/lib/query/compiler.js:166:33)
    at QueryCompiler_SQLite3.toSQL (/home/aemonge/usr/tmp/ghost/node_modules/knex/lib/query/compiler.js:114:27)
    at Builder.toSQL (/home/aemonge/usr/tmp/ghost/node_modules/ghost/node_modules/knex/lib/query/builder.js:115:44)
    at /home/aemonge/usr/tmp/ghost/node_modules/knex/lib/runner.js:52:32
    at tryCatcher (/home/aemonge/usr/tmp/ghost/node_modules/bluebird/js/release/util.js:16:23)
    at /home/aemonge/usr/tmp/ghost/node_modules/bluebird/js/release/using.js:185:26
    at tryCatcher (/home/aemonge/usr/tmp/ghost/node_modules/bluebird/js/release/util.js:16:23)

And this is the fixed output

 ✘ ⚙ aemonge@osboxes  ~/usr/tmp/ghost  knex-migrator --version
3.1.1
 ⚙ aemonge@osboxes  ~/usr/tmp/ghost  knex-migrator init --mgpath node_modules/ghost
[2018-03-06 09:19:25] INFO Creating table: posts
[2018-03-06 09:19:25] INFO Creating table: users
[2018-03-06 09:19:25] INFO Creating table: roles
[2018-03-06 09:19:25] INFO Creating table: roles_users
[2018-03-06 09:19:25] INFO Creating table: permissions
[2018-03-06 09:19:25] INFO Creating table: permissions_users
[2018-03-06 09:19:25] INFO Creating table: permissions_roles
[2018-03-06 09:19:25] INFO Creating table: permissions_apps
[2018-03-06 09:19:25] INFO Creating table: settings
[2018-03-06 09:19:25] INFO Creating table: tags
[2018-03-06 09:19:25] INFO Creating table: posts_tags
[2018-03-06 09:19:25] INFO Creating table: apps
[2018-03-06 09:19:25] INFO Creating table: app_settings
[2018-03-06 09:19:25] INFO Creating table: app_fields
[2018-03-06 09:19:25] INFO Creating table: clients
[2018-03-06 09:19:25] INFO Creating table: client_trusted_domains
[2018-03-06 09:19:25] INFO Creating table: accesstokens
[2018-03-06 09:19:25] INFO Creating table: refreshtokens
[2018-03-06 09:19:25] INFO Creating table: subscribers
[2018-03-06 09:19:25] INFO Creating table: invites
[2018-03-06 09:19:25] INFO Creating table: brute
[2018-03-06 09:19:25] INFO Creating table: webhooks
[2018-03-06 09:19:25] INFO Model: Post
[2018-03-06 09:19:26] INFO Model: Tag
[2018-03-06 09:19:26] INFO Model: Client
[2018-03-06 09:19:26] INFO Model: Role
[2018-03-06 09:19:26] INFO Model: Permission
[2018-03-06 09:19:26] INFO Model: User
[2018-03-06 09:19:27] INFO Relation: Role to Permission
[2018-03-06 09:19:27] INFO Relation: Post to Tag
[2018-03-06 09:19:27] INFO Relation: User to Role
[2018-03-06 09:19:28] INFO Finished database init!

kirrg001 · 2018-03-09T17:58:34Z

@aemonge

Please note: we only support installing dependencies with yarn. There is no package lock file for npm, this can caused wrong dependency trees.

knex-migrator 3.1.4 has bumped knex to the latest version. Latest Ghost master uses 3.1.3, which is correct. The global knex-migrator prefers the local version installed. So i don't see any problem here.

kirrg001 changed the title ~~[WIP] Bump knex-migrator to version 3.0.0~~ [HOLD] Bump knex-migrator to version 3.0.0 Nov 2, 2017

This was referenced Nov 9, 2017

Webhooks support for subscriber events #9230

Merged

feat(db): remove knex-migrator dep, use one installed with Ghost TryGhost/Ghost-CLI#505

Merged

acburdine mentioned this pull request Nov 10, 2017

Update notifications for Ghost-CLI TryGhost/Ghost-CLI#525

Closed

kirrg001 mentioned this pull request Nov 16, 2017

Added Ghost-CLI version range to package.json #9253

Merged

kirrg001 force-pushed the km-3.0 branch from f76d980 to 549e9ad Compare December 4, 2017 14:05

kirrg001 added 8 commits December 4, 2017 15:19

Bump knex-migrator to version 3.0.0

5ab71ed

no issue - adapt major changes - adapt migration scripts - make the scripts easier - ensure rollback of fixtures works [ci skip]

km 3.0 yarn

872aaad

lint

1a10e75

3.0.2

cc801a5

3.0.4

b623764

3.0.5

3b8ef22

3.0.6, fix travis

2edb610

km 3.0.7

cd155f9

kirrg001 force-pushed the km-3.0 branch from 6d6006f to cd155f9 Compare December 4, 2017 14:19

kirrg001 added 7 commits December 4, 2017 15:29

master yarn lock

e923563

km 3.0.7

4c8bd6d

km 3.0.10

3f167cf

Adapt 1.18 migration file

8c81d72

Clear Ghost cache after init

5a00cfe

fixed missing require

c6eca6d

Do not drop tables from init script ATM

18b1fd0

- too dangerous

kirrg001 added 2 commits December 4, 2017 19:53

fix 1.18 script -> messages were wrong

5a5bb86

added docu

465f514

kirrg001 added 2 commits December 5, 2017 08:13

Revert down function for permissions

8f3ac69

km 3.1.0

2c494cd

kirrg001 force-pushed the km-3.0 branch from 38f8920 to 2c494cd Compare December 5, 2017 07:14

km 3.1.1

f927ff8

kirrg001 changed the title ~~[HOLD] Bump knex-migrator to version 3.0.0~~ Bump knex-migrator to version 3.0.0 Dec 5, 2017

kirrg001 changed the title ~~Bump knex-migrator to version 3.0.0~~ Bump knex-migrator to version 3.1.1 Dec 5, 2017

kirrg001 merged commit 0bb81bb into TryGhost:master Dec 5, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump knex-migrator to version 3.1.1 #9199

Bump knex-migrator to version 3.1.1 #9199

kirrg001 commented Nov 1, 2017 •

edited

Loading

kirrg001 commented Nov 7, 2017

kirrg001 commented Nov 10, 2017

kirrg001 commented Dec 4, 2017

kirrg001 commented Dec 4, 2017

aemonge commented Mar 5, 2018

kirrg001 commented Mar 5, 2018

aemonge commented Mar 6, 2018

kirrg001 commented Mar 9, 2018

Bump knex-migrator to version 3.1.1 #9199

Bump knex-migrator to version 3.1.1 #9199

Conversation

kirrg001 commented Nov 1, 2017 • edited Loading

kirrg001 commented Nov 7, 2017

kirrg001 commented Nov 10, 2017

kirrg001 commented Dec 4, 2017

kirrg001 commented Dec 4, 2017

aemonge commented Mar 5, 2018

kirrg001 commented Mar 5, 2018

aemonge commented Mar 6, 2018

kirrg001 commented Mar 9, 2018

kirrg001 commented Nov 1, 2017 •

edited

Loading