Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move xmlrpc & slack to services #9179

Merged
merged 6 commits into from
Oct 25, 2017
Merged

Move xmlrpc & slack to services #9179

merged 6 commits into from
Oct 25, 2017

Conversation

ErisDS
Copy link
Member

@ErisDS ErisDS commented Oct 25, 2017

refs #9178

  • Introduce the /services/ folder
  • Move xmlrpc there
  • Move slack there
  • In slack: remove a usage of the settings API that should use settingsCache
  • In slack: Simplify the tests
  • Various tiny changes to move towards code consistency

@ErisDS ErisDS merged commit e659766 into TryGhost:master Oct 25, 2017
@ErisDS ErisDS deleted the services branch October 25, 2017 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant