Properly return a bluebird promise #8988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs TryGhost#8980 -☹️ apparently this is actually the only way
|
@AileenCGN Could you please add a test for this PR? And could you double check the I would like to figure out if we can remove the promise wrapper, because of 7353c87. |
kirrg001
added a commit
that referenced
this pull request
Dec 13, 2017
refs #9178 - next steps are to A: test if global.Promise works with `got` (see #8988 (comment)) B: re-use request utility everywhere C: request lib requires data/validator, which is dirty
If I remember correctly, we had to wrap the |
So we need to test if we can now remove this because of ^. Do you have time to check that? |
|
I will check tomorrow and try to optimise the tests which needed this wrap. |
|
That is cool! |
aileen
added a commit
to aileen/Ghost
that referenced
this pull request
Jan 2, 2018
refs TryGhost#9178, refs TryGhost#8988 With TryGhost@7353c87 we use Bluebird globally for Promises. Therefore, the request lib doesn't need to be wrapped in a bluebird Promise anymore. This was originally done, so we can work with catch predicated in our image-size lib. Updated the tests to proof, that the catch predicates work. The tests fail, as soon as the Promise overwrite is commented out.
kirrg001
pushed a commit
that referenced
this pull request
Jan 2, 2018
refs #9178, refs #8988 With 7353c87 we use Bluebird globally for Promises. Therefore, the request lib doesn't need to be wrapped in a bluebird Promise anymore. This was originally done, so we can work with catch predicated in our image-size lib. Updated the tests to proof, that the catch predicates work. The tests fail, as soon as the Promise overwrite is commented out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This really didn't make sense to me at first - but the problem is that got() itself returns the wrong kind of promise. We have to instead wrap it. Really annoying because it makes for ugly code, but this is the only way to make sure we can use function predicates everywhere.
FYI I have this wrong in other code 🙈 😞
refs #8980