Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

👷 Add script for supporting calledOnContract matcher in hardhat #755

Merged
merged 6 commits into from
Jul 13, 2022
Merged

👷 Add script for supporting calledOnContract matcher in hardhat #755

merged 6 commits into from
Jul 13, 2022

Conversation

yivlad
Copy link
Collaborator

@yivlad yivlad commented Jul 13, 2022

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Jul 13, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: e4ada66

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

rzadp
rzadp reviewed Jul 13, 2022
View reviewed changes
waffle-hardhat/test/test-setup.ts
@@ -0,0 +1 @@
import '../src/inject-call-history';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a little bit weird, a file with side effects that also contains a class definition.
Maybe export injectCallHistory and execute it here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's actually better to do this way to ensure that this is the first thing that gets executed

@yivlad yivlad merged commit 3ac5546 into master Jul 13, 2022
@yivlad yivlad deleted the yivlad/hardhat-called-on-contract branch July 13, 2022 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rzadp rzadp rzadp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yivlad @rzadp