Change changeBalance matcher type #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return Promise.all(signers.map((signer) => getAddressOf(signer))); | ||
| } | ||
|
|
||
| async function getBalanceOf(account: Signer | Contract) { |
There was a problem hiding this comment.
Extract to common file
|
|
||
| export function supportChangeBalances(Assertion: Chai.AssertionStatic) { | ||
| Assertion.addMethod('changeBalances', function ( | ||
| this: any, | ||
| signers: Signer[], | ||
| signers: (Signer | Contract)[], |
There was a problem hiding this comment.
Extract common type Account?
waffle-chai/src/matchers/common.ts
Outdated
| @@ -0,0 +1,19 @@ | |||
| import {Contract, Signer} from 'ethers'; | |||
There was a problem hiding this comment.
I would rename file to misc/account.ts
marekkirejczyk
approved these changes
Sep 22, 2020
duckception
force-pushed
the
contract-balance-matcher
branch
2 times, most recently
from
0c52818 to
ccdd132
Compare
duckception
force-pushed
the
contract-balance-matcher
branch
from
ccdd132 to
f61d7c7
Compare
This was referenced Sep 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.