Injectable URLs and check window to ensure Cordova is not already defined #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a few changes to assist in Cordova-wrapping an SPA, and I thought the changes may be beneficial to someone else.
Add an CRIInjectableSites preference that accepts wildcard URLs. This prevents the javascript from being injected on every request. It seems like a preventive measure to ensure JS is not injected where it is not wanted.
Add a window.cordova == null check to prevent Cordova from being injected multiple times. I have found this occurs when making asynchronous web calls from the initial page.
Let me know what you think. Thanks!