#[ldtk_int_cell], #[from_entity_instance] etc. should not require a Default impl
#305
Comments
Merged
neocturne
added a commit
to neocturne/bevy_ecs_ldtk
that referenced
this issue
Mar 2, 2024
…acros Add an attribute that initializes fields using individual field Default implementations, allowing to use the derive macros again without requiring the whole struct to implement Default (when some fields should be default-initialized and others use initialization attributes like #[from_entity_instance]). Fixes Trouv#305
Trouv
pushed a commit
to neocturne/bevy_ecs_ldtk
that referenced
this issue
Jul 9, 2024
…acros Add an attribute that initializes fields using individual field Default implementations, allowing to use the derive macros again without requiring the whole struct to implement Default (when some fields should be default-initialized and others use initialization attributes like #[from_entity_instance]). Fixes Trouv#305
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Since #222,
Defaultmust be implemented to deriveLdtkEntity,LdtkIntCelletc.This does not interact well with
#[from_entity_instance]and similar attributes, as I was using the attributes on fields where there is no reasonable way to implementDefault(like a struct containing aBox<dyn ...>). With the change, I either have to:impl Defaultfor my field to I can derive it for myLdtkEntitytype, orimpl Defaultfor myLdtkEntitytype, still requiring me to create a field instance out of thin airWhile I could make up some value just to be able to implement
Default, doing so would feel like a misuse of theDefaulttrait.The text was updated successfully, but these errors were encountered: