Skip to content

Commit

Permalink
tools: only sign release if promotion successful
Browse files Browse the repository at this point in the history
Ref: nodejs/build#1596

PR-URL: nodejs#24669
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
rvagg authored and Trott committed Dec 1, 2018

Verified

This commit was signed with the committer’s verified signature. The key has expired.
addaleax Anna Henningsen
1 parent 84c2157 commit f34ca9f
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion tools/release.sh
Original file line number Diff line number Diff line change
@@ -202,7 +202,9 @@ for version in $versions; do

ssh ${customsshkey} ${webuser}@${webhost} $promotecmd nodejs $version

sign $version
if [ $? -eq 0 ];then
sign $version
fi

break
done

0 comments on commit f34ca9f

Please sign in to comment.