cPanel won't recognize PG as installed for the purposes of WHM & cPanel UIs when upgraded

[troglodyne]

The silly regexp in our haspostgres check just doesn't pick up on the RPM names.

Will have to figure out some way to dope out the globalcache.

[troglodyne]

Will try to knock this out soon

[troglodyne]

# perl -mCpanel::DbUtils -e 'print Cpanel::DbUtils::find_psql() . "\n" . Cpanel::DbUtils::find_postmaster() .  "\n";'      
/usr/bin/psql

So, looks like /usr/local/cpanel/Cpanel/PostgresAdmin/Check.pm fails the check due to not being able to find the postmaster.
Will have to investigate Cpanel/DbUtils.pm now

[troglodyne]

# which postmaster
/usr/bin/which: no postmaster in (/usr/local/cpanel/3rdparty/lib/path-bin:/usr/local/sbin:/sbin:/bin:/usr/sbin:/usr/bin:/opt/cpanel/composer/bin:/root/bin)

[troglodyne]

Looks like I need to additionally link postmaster with update-alternatives

[troglodyne]

So, if I do this, I get an interesting result from build_global_cache:

root@hydra cpanel  # bin/build_global_cache
Building global cache for cpanel...Use of uninitialized value $pmajor in numeric lt (<) at /usr/local/cpanel/Cpanel/PostgresAdmin/Check.pm line 65.
Use of uninitialized value $pmajor in concatenation (.) or string at /usr/local/cpanel/Cpanel/PostgresAdmin/Check.pm line 66.
Use of uninitialized value $pminor in concatenation (.) or string at /usr/local/cpanel/Cpanel/PostgresAdmin/Check.pm line 66.
Done

Probably the same thing where on PG 10 I had to write my own version getter due to the cP regexp being a disaster

[troglodyne]

yep, this check is still bonehead:

teo@hydra better-postgres4cP (master) $ postmaster --version
postgres (PostgreSQL) 10.13

In the code:

 60     my $psqlversion = Cpanel::GlobalCache::cachedcommand( 'cpanel', $postmaster, '--version' );
 61     if ($psqlversion) {
 62         $psqlversion =~ m/(\d+)\.(\d+)\.\d+/;
 63         my $pmajor = $1;
 64         my $pminor = $2;
 65         if ( $pmajor < 7 || ( $pmajor == 7 && $pminor < 3 ) ) {
 66             return { 'status' => 0, 'message' => "PostgreSQL version is not sufficient. Version $pmajor.$pminor is not supported." };
 67         }
 68         $short_version = $pmajor . '.' . $pminor;
 69     }
 70     else {
 71         return { 'status' => 0, 'message' => 'Failed to determine PostgreSQL version from server.' };
 72     }

Why does it look for the third dot when it totally isn't used? This seems like bullshit to me.
Gonna file this internally, as this level of specificity is neither necessary or helpful.

[troglodyne]

So, monkeypatched that to fix that check, now haspostgres looks good

Problem is the service driver is disaster now:

Waiting for “postgresql” to start ………failed.

Cpanel::Exception::Services::StartError Service Status
undefined status from Cpanel::ServiceManager::Services::Postgresql

Service Error
(XID b2rj2z) The “postgresql” service failed to start.

Startup Log
pg_ctl: cannot be run as root
Please log in (using, e.g., "su") as the (unprivileged) user that will
own the server process.

postgresql has failed. Contact your system administrator if the service does not automagically recover.

Service Changes Complete

[troglodyne]

Filed CPANEL-33721 internally about the PG version check, gonna split the pg service driver stuff out into its' own issue

[troglodyne]

Fix coming in cPanel v92