Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor AuthContext for Firebase 9 and fix remember me bug #70

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

typokign
Copy link
Member

@typokign typokign commented Dec 6, 2021

Administrative Info

Monday Board ID: 853642866

Should simplify things a little bit, and more importantly fix a bug where expired credentials were being cached, breaking remember me functionality.

@typokign typokign requested a review from a team December 6, 2021 02:24
@tse-awesome-tool
Copy link

This PR is linked to Item 1983666230 on Board 853642866 and has now been put into Code Review status!

Copy link
Contributor

@ryanbuui ryanbuui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants