-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Firebase sign-in implementation and error states #22
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job on this task! Couple things I noticed that we discussed at our last dev meeting:
- If the email is not verified, they shouldn't be able to sign in. Maybe we can refactor the code to make it that once the email is verified it adds to the Firebase and Mongo? another option (probably easier) is that we could just add an error that says something like "Email not verified, please check your email". One issue I see with this that might happen is for example if someone creates an account and doesn't verify their email. When they try to sign in and see the error, they might not have received the email and there is no way for them to resend it, and our current implementation won't let them resend the email after they exit the resend page. I hope that makes sense. Let me
know what you think and we can discuss this. - The second thing we would want to implement is a way to determine if it is their first time signing in. If it is their first time signing in we want to take them to the intro video page, if it isn't they can go straight to the home page. This could be easy maybe you could just make a boolean field
firstSignIn
in Mongo. There might be a way with Firebase to do that too, but I think the field might be easiest.
Let me know if you have any questions about this, great work!
Changes made! Also merged with Kevin's work on debugging user authentication. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #22 (comment)
…e if backend/mongodb doesn't work
Fixes/Changes since Sweekrit's first comment:
Screen.Recording.2025-02-20.at.1.01.48.AM.mov
![]()
Let us know if you notice anything else that needs changing! |
Changes
Added sign-in implementation on Firebase and added the appropriate error states.
Testing
Tested changes through independent verification -> if email and password were incorrect, then error states were raised. If they were correct, console.log and redirected to the homepage.
Correct password, incorrect username:

Correct username, incorrect password

Email is invalid

After sign in
