Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mysql-server-5.6.28: my.cnf incorrectly placed in /opt/local instead of /opt/local/etc #378

Closed
peterkelm opened this issue Jun 12, 2016 · 2 comments
Assignees

Comments

@peterkelm
Copy link

When installing mysql-server-5.6.28 from Joyent pkgsrc (http://pkgsrc.joyent.com/packages/SmartOS/2015Q4) „my.cnf“ is placed in /opt/local instead of /opt/local/etc

Accordingly, /opt/local/my.cnf isn’t even looked at as it is not in one of the default locations. From „mysqld —help“: „Default options are read from the following files in the given order: /etc/my.cnf /etc/mysql/my.cnf /opt/local/etc/my.cnf ~/.my.cnf“

@mamash mamash self-assigned this Jun 13, 2016
@mamash
Copy link

mamash commented Jun 14, 2016

Thanks, Peter. I committed a fix to upstream pkgsrc trunk today, so it will show up in 2016Q2.

The MySQL upstream intentionally uses $PREFIX ($basedir) as the right location for my.cnf. I patched that to play along with the pkgsrc expectations. (MySQL prior to 5.6 did not try to install any designated my.cnf file.)

@peterkelm
Copy link
Author

Filip,

Thanks for the update. I’ll test it out when 2016Q2 becomes available.

Best regards,

Peter

Am 14.06.2016 um 15:31 schrieb Filip Hajny [email protected]:

Thanks, Peter. I committed a fix to upstream pkgsrc trunk today, so it will show up in 2016Q2.

The MySQL upstream intentionally uses $PREFIX ($basedir) as the right location for my.cnf. I patched that to play along with the pkgsrc expectations. (MySQL prior to 5.6 did not try to install any designated my.cnf file.)


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub TritonDataCenter/pkgsrc#378 (comment), or mute the thread https://github.com/notifications/unsubscribe/ALg9mSQdsw-FUlPV7Y7eZi5WLt1oYyg8ks5qLq0UgaJpZM4Iz3He.

@mamash mamash closed this as completed Jun 15, 2016
jperkin pushed a commit that referenced this issue Oct 22, 2016
version 1.11.1: 2016-06-14

    * new guesser infrastructure, support for emacs and vim modelines (#489)
    * javascript bugfix for nested objects with quoted keys (#496)
    * new theme: Gruvbox (thanks @jamietanna!)
    * praat: lots of improvements (thanks @jjatria)
    * fix for rougify error when highlighting from stdin (#493)
    * new lexer: kotlin (thanks @meleyal!)
    * new lexer: cfscript (thanks @mjclemente!)

version 1.11.0: 2016-06-06

    * groovy:
	o remove pathological regexes and add basic support for
	  triple-quoted strings (#485)
	o add the "trait" keyword and fix project url (thanks @glaforge! #378)
    * new lexer: coq (thanks @gmalecha! #389)
    * gemspec license now more accurate (thanks @connorshea! #484)
    * swift:
	o properly support nested comments (thanks @dblessing! #479)
	o support swift 2.2 features (thanks @radex #376 and @wokalski #442)
	o add indirect declaration (thanks @nRewik! #326)
    * new lexer: verilog (thanks @Razer6! #317)
    * new lexer: typescript (thanks @Seikho! #400)
    * new lexers: jinja and twig (thanks @robin850! #402)
    * new lexer: pascal (thanks @alexcu!)
    * css: support attribute selectors (thanks @skoji! #426)
    * new lexer: shell session (thanks @sio4! #481)
    * ruby: add support for <<~ heredocs (thanks @tinci! #362)
    * recognize comments at EOF in SQL, Apache, and CMake (thanks @julp! #360)
    * new lexer: phtml (thanks @Igloczek #366)
    * recognize comments at EOF in CoffeeScript (thanks @rdavila! #370)
    * c/c++:
	o support c11/c++11 features (thanks @Tosainu! #371)
	o Allow underscores in identifiers (thanks @coverify! #333)
    * rust: add more builtin types (thanks @RalfJung! #372)
    * ini: allow hyphen keys (thanks @KrzysiekJ! #380)
    * r: massively improve lexing quality (thanks @klmr! #383)
    * c#:
	o add missing keywords (thanks @BenVlodgi #384 and @SLaks #447)
    * diff: do not require newlines at the ends (thanks @AaronLasseigne! #387)
    * new lexer: ceylon (thanks @bjansen! #414)
    * new lexer: biml (thanks @japj! #415)
    * new lexer: TAP - the test anything protocol (thanks @mblayman! #409)
    * rougify bugfix: treat input as utf8 (thanks @japj! #417)
    * new lexer: jsonnet (thanks @davidzchen! #420)
    * clojure: associate *.cljc for cross-platform clojure (thanks @alesguzik! #423)
    * new lexer: D (thanks @nikibobi! #435)
    * new lexer: smarty (thanks @tringenbach! #427)
    * apache:
	o add directives for v2.4 (thanks @stanhu!)
	o various improvements (thanks @julp! #301)
	    - faster keyword lookups
	    - fix nil error on unknown directive (cf #246, #300)
	    - properly manage case-insensitive names (cf #246)
	    - properly handle windows CRLF
    * objective-c:
	o support literal dictionaries and block arguments (thanks @BenV!
	  #443 and #444)
	o Fix error tokens when defining interfaces (thanks @meleyal! #477)
    * new lexer: NASM (thanks @sraboy! #457)
    * new lexer: gradle (thanks @nerro! #468)
    * new lexer: API Blueprint (thanks @kylef! #261)
    * new lexer: ActionScript (thanks @honzabrecka! #241)
    * terminal256 formatter: stop confusing token names (thanks @julp! #367)
    * new lexer: julia (thanks @mpeteuil! #331)
    * new lexer: cmake (thanks @julp! #302)
    * new lexer: eiffel (thanks @Conaclos! #323)
    * new lexer: protobuf (thanks @fqqb! #327)
    * new lexer: fortran (thanks @CruzR! #328)
    * php: associate *.phpt files (thanks @Razer6!)
    * python: support raise from and yield from (thanks @mordervomubel! #324)
    * new VimL example (thanks @tpope! #315)
jperkin pushed a commit that referenced this issue Oct 22, 2016
Restrict to ruby22 and ruby23.

v3.1.5

Bugfixes

    * #394 prevent crashes when Listen is stopped too soon (e.g. before
      being started or initialized)


v3.1.4

Bugfixes

    * #393 - relaxed rb-fsevent dependency to allow install on older OSX
      releases (thanks to @robmckinnon)


v3.1.3

Bug fixes

    * #387 - fix JRuby support both in dependencies (by allowing Ruby 2.2.3)
      and behavior (JRuby Dir.entries workaround)
    * #387 - prevent JRuby from hanging when stopping on Linux (and Travis)
    * #387 - activate JRuby-9.0.5.0 on Travis to declare support for JRuby
      (tests are flaky, but that's due to timing issues)


v3.1.2

Security enhancements

    * #377 require at least Ruby 2.2.4 to avoid CVE-2015-7551 (see
      https://www.ruby-lang.org/en/news/2015/12/16/ruby-2-2-4-released/)

Bugfixes

    * #383 allow stopping when not fully initialized (fixes guard/guard#822
      (comment))

Improvements

    * #378 warn users if their Ruby is buggy or vulnerable (controversial to
      some, but very extensively justified)

Development

    * #377 use ruby_dep for managing ruby requirements
    * #379 make RuboCop pass (thanks to @jvanbaarsen)
    * #384 avoid rubygems duplicate dependency error (gem given in both
      runtime and development dependencies)


v3.1.1

Bugfixes

    * #373 explicitly require forwardable for delegation (fixes #372)


v3.1.0

Bugfixes

    * #370 - gracefully fallback to polling on old older unsupported OSX
      versions (thanks to @vaz)

Improvements

    * #371 - update dependency to Ruby 2.2.x since 2.1 and earlier are EOL
      (minor version bumped to 3.1 in case backporting is needed)

Development

    * #371 - fix all RuboCop offenses to avoid noise during development
jperkin pushed a commit that referenced this issue Dec 27, 2016
Update DEPENDS(upstream dropped php-5.3 support)

Upstream changes:
Version 9.1.3 Dec 13 2016

    [major] UI: File list now works properly with many hidden entries - core/#26518
    [major] Transfer ownership fails in some sharing scenario - core/#26523
    [major] Transfer ownership fails if external storage with user-specified password - core/#26530
    [major] Transfer ownership fails with file shares with invalid permissions - core/#26541
    [major] Transfer ownership must skip trashed shares - core/#26525
    [major] Versions on external storage never expire - core/#24161
    [major] Properly convert public upload OCS params - core/#26691
    [major] Properly load object store apps at install time when required in config - core/#26299
    [major] Fix issue in sharing API that can happen with Galera Cluster - core/#26700
    [major] Cannot delete file in share link from global external storage - core/#25618
    [major] Fix issue where first run wizard made web UI unusable in IE11 - core/#26438
    [major] Cannot upload to federated share when only create/update permission given - core/#26173
    [major] Auth header in new DAV endpoint can break with Windows Webdav - core/#26412
    [minor] Transfer ownership don't bail out on error - core/#26524
    [minor] Don't scan received shares in OCC files scan or background jobs - core/#26590
    [minor] Remove useless warning in log when accessing public shares - core/#25455
    [minor] Fix disappearance of share info when clicking favorite star - core/#26241
    [minor] Don't bother fetching preview images if previews disabled in config.php - core/#26705

Version 9.1.2 Nov 8 2016

    Core: Adjusted documentation link to issue template - core/#26087
    Core: Display feedback in users page when changing password - core/#25532
    Core: Fix mime type detection in hidden directories - core/#26133
    Core: Change forum URL to central - core/#25644
    Core: Fix share array format passed to "post_unshareFromSelf" hook - core/#26390
    Core: Release mount info memory after running background jobs - core/#26223
    Core: Improve users page performance by not sorting after every add - core/#26234
    Core: Escape special chars in some queries - core/#25429
    Core: Redirect to two factor challenge page when only a single provider exists - core/#26134
    Core: Fix bogus PasswordLoginForbidden DAV error when logging in as non-existing user - core/#26123
    Core: Change the minimum log level to FATAL - core/#26131
    Core: Fix issue with "(2)" appearing on shares when querying avatar with wrong casing - core/#26271
    Core: Enabling an app now also analyzes dependencies at this time instead of only at install - core/#26295
    Core: Reuse cached app info to avoid high load on some environments - core/#25603
    Core: Show warning instead of exception when trying to run ownCloud on Windows - core/#26208
    Core: Fix misleading SSL/TLS SMTP email configuration - core/#26447
    Core: Fix malformed attribute in files app page - core/#26480
    DAV: Improve chunk assembly performance for new DAV endpoint - core/#26062
    DAV: New chunking now returns Etag and OC-Etag on the final MOVE - core/#25682
    DAV: Do not print exception messages in HTML - core/#26460
    DAV: Sanitize length headers when validating quota - core/#26366
    Files: Allow uploading empty files in the web UI - core/#19116
    Files: Properly translate file summary in lists - core/#26221
    Files: Exclude more invalid chars in path - core/#26461
    Sharing: Let the share owner increase permissions - core/#25542
    Federation: Fix sharing with remote user names containing spaces - core/#25955
    Federation: Save some memory in sync job by releasing mount info after each user - core/#26204
    Federation: Fix federated address book syncing by using the correct background job name - core/#26202
    CalDAV: Add Schedule and IMip plugins when receiving webdav v1 api calendar calls - core/#23600
    CardDAV: Unset photo before setting a new one - core/#26242
    CardDAV: Fix for birthday entries - core/#25636
    CardDAV: Limit image export mime types - core/#26459
    Updater: Fix web UI update in some environments - updater/#378
    Updater: Retrigger integrity check after update - updater/#405
    User_LDAP: Added OCC command to update group mappings - user_ldap/#14
    User_LDAP: Fix issue with "(2)" appearing on shares when refreshing users in some scenarios - core/#25718
    User_external: Double verify the SMB response - apps/#2198
    Firstrunwizard: Only display the wizard when in files app - firstrunwizard/#52
    Gallery: Do not display technical error messages - gallery/#707
jperkin pushed a commit that referenced this issue Mar 20, 2017
# Change Log

## [3.5.5] - 2017-02-24

[3.5.5]: hashie/hashie@v3.5.4...v3.5.5

### Added

* [#326](hashie/hashie#326): Added `Hashie::Extensions::Mash::KeepOriginalKeys` to give Mashes the ability to keep the original structure given to it - [@michaelherold](https://github.com/michaelherold).

### Fixed

* [#415](hashie/hashie#415): Fixed Mash logging keys multiple times which lead to a bad user experience or, in some cases, errors - [@michaelherold](https://github.com/michaelherold).

## [3.5.4] - 2017-02-22

[3.5.4]: hashie/hashie@v3.5.3...v3.5.4

### Added

* [#412](hashie/hashie#412): Added a Hashie::Extensions::Mash::SymbolizeKeys extension that overrides the default stringification behavior for keys - [@michaelherold](https://github.com/michaelherold).

### Fixed

* [#409](hashie/hashie#409): Fixed Railtie detection for projects where Rails is defined but Railties are not availble - [@CallumD](https://github.com/callumd).
* [#411](hashie/hashie#411): Fixed a performance regression from 3.4.3 that caused a 10x slowdown in OmniAuth - [@michaelherold](https://github.com/michaelherold).

## [3.5.3] - 2017-02-11

[3.5.3]: hashie/hashie@v3.5.2...v3.5.3

### Fixed

* [#402](hashie/hashie#402): Use a Railtie to set Hashie.logger on rails boot - [@matthewrudy](https://github.com/matthewrudy).
* [#406](hashie/hashie#406): Ensure that subclasses that disable warnings propagate that setting to grandchild classes - [@michaelherold](https://github.com/michaelherold).
* Your contribution here.

## [3.5.2] - 2017-02-10

[3.5.2]: hashie/hashie@v3.5.1...v3.5.2

### Added

* [#395](hashie/hashie#395): Add the ability to disable warnings in Mash subclasses - [@michaelherold](https://github.com/michaelherold).
* [#400](hashie/hashie#400): Fix Hashie.logger load and set the Hashie logger to the Rails logger in a Rails environment - [@michaelherold](https://github.com/michaelherold).

### Fixed

* [#396](hashie/hashie#396): Fix for specs in #381: Incorrect use of shared context meant example was not being run - [@biinari](https://github.com/biinari).
* [#399](hashie/hashie#399): Fix passing Pathname object to Hashie::Mesh.load() - [@albb0920](https://github.com/albb0920).

### Miscellanous

* [#397](hashie/hashie#397): Add the integration specs harness into the main test tasks - [@michaelherold](https://github.com/michaelherold).

## [3.5.1] - 2017-01-31

* [#392](hashie/hashie#392): Fix for #391: Require all dependencies of Hashie::Mash - [@dblock](https://github.com/dblock).

[3.5.1]: hashie/hashie@v3.5.0...v3.5.1

## [3.5.0] - 2017-01-31

* [#386](hashie/hashie#386): Fix for #385: Make `deep_merge` always `deep_dup` nested hashes before merging them in so that there are no shared references between the two hashes being merged. - [@mltsy](https://github.com/mltsy).
* [#389](hashie/hashie#389): Support Ruby 2.4.0 - [@camelmasa](https://github.com/camelmasa).

[3.5.0]: hashie/hashie@v3.4.6...v3.5.0

### Added

* [#381](hashie/hashie#381): Add a logging layer that lets us report potential issues to our users. As the first logged issue, report when a `Hashie::Mash` is attempting to overwrite a built-in method, since that is one of our number one questions - [@michaelherold](https://github.com/michaelherold).

### Changed

* [#384](hashie/hashie#384): Updated to CodeClimate 1.x - [@boffbowsh](https://github.com/boffbowsh).

### Fixed

* [#369](hashie/hashie#369): If a translation for a property exists when using IndifferentAccess and IgnoreUndeclared, use the translation to find the property - [@whitethunder](https://github.com/whitethunder).
* [#376](hashie/hashie#376): Leave string index unchanged if it can't be converted to integer for Array#dig - [@sazor](https://github.com/sazor).
* [#377](hashie/hashie#377): Dont use Rubygems to check ruby version - [@sazor](https://github.com/sazor).
* [#378](hashie/hashie#378): Deep find all searches inside all nested hashes - [@sazor](https://github.com/sazor).
* [#380](hashie/hashie#380): Evaluate procs default values of Dash in object initialization - [@sazor](https://github.com/sazor).

### Miscellanous

* [#387](hashie/hashie#387): Fix builds failing due to Rake 11 having a breaking change - [@michaelherold](https://github.com/michaelherold).
jperkin pushed a commit that referenced this issue Mar 20, 2017
## [1.12.0][] (2017-02-10)

### Breaking changes

  * None

### New features

  * Add `SSHKit.config.default_runner_config` option that allows overriding default runner configs.

## [1.11.5][] (2016-12-16)

### Bug fixes

  * Do not prefix `exec` command
    [PR #378](capistrano/sshkit#378) @dreyks

## [1.11.4][] (2016-11-02)

  * Use string interpolation for environment variables to avoid escaping issues
    with sprintf
    [PR #280](capistrano/sshkit#280)
    @Sinjo - Chris Sinjakli
wiedi pushed a commit to wiedi/pkgsrc-legacy that referenced this issue Jan 28, 2018
pkgsrc changes:
- switch to using qt5 (to follow upstream)
- handle ${PREFIX} in more places
- fix package COMMENT (remove "for IBus")
- GCC_REQD 4.7 for c++11
- add patch comments

See PR pkg/52689 for more details.

Upstream changes:
(from https://github.com/google/mozc/blob/master/docs/release_history.md)

Summary of changes between 2.19.2644.102 and 2.20.2673.102 as follows.

    Third party libraries:
        None.
    Build related changes:
        --qtver GYP build option was removed (280e38f).
        Mozc for macOS now uses macOS 10.11 SDK by default (b2a74bb).
    Major changes:
        src/data/installer/credits_ja.html was removed (2ec6c8f).
        Mozc for macOS now generates 64-bit executables. 32-bit machine is no longer supported on macOS.
        Mozc for Android now has more translations (d914458).
    Fixed issues:
        TritonDataCenter#187: build_mozc.py always generates 32 bit binaries on 64 bit OSX
        TritonDataCenter#327: Switch to Qt5 from Qt4
        TritonDataCenter#348: DirectWrite may fail to render text in certain enviromnents
        TritonDataCenter#391: ImportError: gen_zip_code_seed.py
        TritonDataCenter#399: OK/Cancel buttons on Mozc key binding editor dialog cannot be clicked on Windows
        TritonDataCenter#400: Close icon on GUI dialogs do not work on Windows
    Total commits:
        30 commits.

Summary of changes between 2.18.2613.102 and 2.19.2643.102 as follows.

    Third party libraries:
        protobuf: e8ae137 -> c44ca26
        Dropped dependency on fonttools
    Build related changes:
        --qtver=5 GYP build option is implicitly assumed on macOS and Linux builds (f76c304). On Windows, --qtver=4 is still the default.
    Major changes:
        Mozc for macOS now supports 10.12 as a runtime environment.
        Mozc for Android now uses on-device font to render keytop icons (f5dcad).
    Fixed issues:
        TritonDataCenter#263: Incorrect position in voiced sound marks on the key pad in Android
        TritonDataCenter#384: HUAWEI P9 lite does not show MozcView.
        TritonDataCenter#388: Having multiple abbreviation user dictionary entries with the same reading should be supported
        TritonDataCenter#389: Emoticon user dictionary entry should not be treated a content word
    Total commits:
        39 commits.

Summary of changes between 2.17.2532.102 and 2.18.2612.102 as follows.

    Third party libraries:
        protobuf: d5fb408 -> e8ae137
        GYP: e2e928b -> 4ec6c4e
        breakpad: d2904bb -> 85b27e4
        Dropped dependency on zlib
    Build related changes:
        Renamed src/mozc_version_template.txt to src/data/version/mozc_version_template.bzl
        Reference build environment now uses Ubuntu 14.04.5 (a7cbf72)
        Reference build environment now uses Ninja 1.7.1 (d2bc62b)
        Removed --android_compiler GYP option (5ce7fa6)
        Android build requires Android NDK r12b (5ce7fa6)
    Major changes:
        Improved Store Apps compatibility on Windows (0488082)
    Fixed issues:
        NPE in UserDictionaryToolActivity.onPostResume on Android (09b47c3)
        TritonDataCenter#273: Compilation errors in Android arm64 and mips64 build
        TritonDataCenter#373: Unexpected size bloat of the APK
        TritonDataCenter#374: Duplicate candidates after Undo
        TritonDataCenter#375: 90- is suggested from 090-
        TritonDataCenter#376: Suggestion-only user dictionary entry may not work
        TritonDataCenter#377: Abbreviation user dictionary entry may not work
        TritonDataCenter#378: Suppression word may not work
        TritonDataCenter#379: Single character noun user dictionary entry may not work
        TritonDataCenter#380: Dependency on dictionary/pos_matcher.h from session/session_server.cc is missing in GYP rules
        TritonDataCenter#382: Fix typo
    Total commits:
        84 commits.

Summary of changes between 2.17.2405.102 and 2.17.2531.102 as follows.

    Third party libraries:
        protobuf: 1a59a71 -> d5fb408
    Build related changes:
        Building Mozc for Windows requires Visual Studio 2015 update 3.
        --qtdir option is no longer supported in Linux desktop build (d003076).
    Major changes:
        Updated system dictionary.
        Removed several Shift-JIS-based normalizations on Windows (26241b0).
        Mozc for Windows requires SSE2 even on 32-bit environment.
        Mozc for Windows supports Windows 7 SP1 and later only.
        Mozc for macOS supports macOS 10.9 and later only.
        Mozc for desktop platforms (Windows, macOS, desktop Linux) supports Qt5 behind --qtver=5 GYP option.
    Fixed issues:
        Fix OOM when importing too large dictionary file on Android (5c859ae)
        TritonDataCenter#298: Fix NPE on Samsung devices on showing toast
        TritonDataCenter#315: Switch to Visual C++ 2015
        TritonDataCenter#372: Discontinue the support of Windows Vista
    Total commits:
        128 commits.

Summary of changes between 2.17.2355.102 and 2.17.2404.102 as follows.

    Third party libraries:
        protobuf: 172019c -> 1a59a71
    Build related changes:
        Building Mozc requires protobuf 3.0 or later.
        --android_stl GYP option is removed in Android build. You cannot use GNU STL to build Mozc for Android anymore.
    Major changes:
        None.
    Fixed issues:
        TritonDataCenter#369: Unexpected software keyboard layout can be chosen
        TritonDataCenter#370: Mozc keeps crashing on Android N Developer Preview 5
        TritonDataCenter#371: Shortcut word in personal dictionary should not be used for multi segment conversion
    Total commits:
        50 commits.

Summary of changes between 2.17.2323.102 and 2.17.2354.102 as follows.

    Third party libraries:
        None.
    Build related changes:
        None.
    Major changes:
        2.17.2323.102 and later commits in OSS repository preserve the original CL commit date in Google internal repository.
            Consider to specify --topo-order option to git log to see commits in the actual commit order.
        Multiple performance improvements in Android.
    Fixed issues:
        None.
    Total commits:
        32 commits.

Summary of changes between 2.17.2314.102 and 2.17.2322.102 as follows.

    Third party libraries:
        googletest: 1d53731 -> 82b11b8
        WTL: 9.0.4140 -> 9.1.5321
    Build related changes:
        Building macOS binaries now requires Ninja instead of xcodebuild.
    Major changes:
        None.
    Fixed issues:
        TritonDataCenter#247: Use ninja to build Mac binaries
        TritonDataCenter#355: Native resource leak due to the missing pthread_detach call in mozc::Thread::Detach
        TritonDataCenter#361: ImmSetCandidateWindow() with CFS_EXCLUDE isn't supported on Win Vista and Win7
    Total commits:
        15 commits.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants