Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KeyPair isKey assertion should be min-versioned #16

Open
arekinath opened this issue Apr 20, 2018 · 0 comments
Open

KeyPair isKey assertion should be min-versioned #16

arekinath opened this issue Apr 20, 2018 · 0 comments

Comments

@arekinath
Copy link

Currently when there's an sshpk release newer than the sshpk-agent one available and there's a Key format change, you can get errors like this:

mls: AssertionError: options.public must be a sshpk.Key instance
    at AgentKeyPair.SDCKeyPair (/usr/local/lib/node_modules/manta/node_modules/smartdc-auth/lib/keypair.js:50:14)
    at new AgentKeyPair (/usr/local/lib/node_modules/manta/node_modules/smartdc-auth/lib/kr-agent.js:93:10)
    at /usr/local/lib/node_modules/manta/node_modules/smartdc-auth/lib/kr-agent.js:81:14
    at Request.r_cb (/usr/local/lib/node_modules/manta/node_modules/sshpk-agent/lib/client.js:59:3)
    at Request.state_done (/usr/local/lib/node_modules/manta/node_modules/sshpk-agent/lib/client-fsm.js:224:8)
    at Request.FSM._gotoState (/usr/local/lib/node_modules/manta/node_modules/mooremachine/lib/fsm.js:325:4)
    at FSMStateHandle.gotoState (/usr/local/lib/node_modules/manta/node_modules/mooremachine/lib/fsm.js:76:23)
at Client.<anonymous> (/usr/local/lib/node_modules/manta/node_modules/sshpk-agent/lib/client-fsm.js:190:5)
    at emitOne (events.js:96:13)
    at Client.emit (events.js:188:7)

This is because in keypair.js we're using Key.isKey from sshpk in an assertion without giving it a minimum version we require, so it's assuming we need the latest.

joyent-automation pushed a commit that referenced this issue Apr 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant