Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client could support accepting fully qualified upload directory as input to MPU operations #326

Closed
jordanhendricks opened this issue Sep 15, 2017 · 1 comment

Comments

@jordanhendricks
Copy link
Contributor

jordanhendricks commented Sep 15, 2017

With the integration of MANTA-3427, the prefix length on MPU directories will be a tunable. As it today, the client assumes a prefix length of 1. Issue #325 will allow the client to resolve the prefix length, allowing tools that just use the upload ID to continue to work.

Because long-lived client sessions likely don't want to incur an additional latency hit to resolve the fully qualified upload directly path for each MPU operation, this change will allow additional flexibility: providing the fully qualified path to the client directly.

This change will be a minor version bump, as it will augment the API in a backwards compatible manner.

@jordanhendricks
Copy link
Contributor Author

CR is at: https://cr.joyent.us/#/c/2592/.

Testing Notes

  • This change is make check clean.
  • Ran the test suite using make test.
  • Ran the muskie test suite with a version of node-manta using this change, and it passes.

joyent-automation pushed a commit that referenced this issue Sep 16, 2017
…as input to MPU operations

Reviewed by: David Pacheco <[email protected]>
Reviewed by: Joshua M. Clulow <[email protected]>
Approved by: Joshua M. Clulow <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant