Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

forEachKey() should ignore inherited properties #15

Closed
davepacheco opened this issue Jun 22, 2016 · 1 comment
Closed

forEachKey() should ignore inherited properties #15

davepacheco opened this issue Jun 22, 2016 · 1 comment

Comments

@davepacheco
Copy link
Contributor

forEachKey() currently iterates enumerable properties, but it should ignore non-own properties, since that's generally what people intend. We're doing this as a non-major semver change because it's assumed that this will not break existing programs.

See https://developer.mozilla.org/en-US/docs/Web/JavaScript/Enumerability_and_ownership_of_properties for details.
davepacheco pushed a commit that referenced this issue Jun 23, 2016
#14 add safer version of hasOwnProperty()
b5acfc2 
#15 forEachKey() should ignore inherited properties
Reviewed by: Joshua M. Clulow <[email protected]>
Reviewed by: Alex Wilson <[email protected]>
@davepacheco
Copy link
Contributor Author

This was done a while ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@davepacheco