MANTA-4387 [mantav1] update Moray to use artedi v2 fixed buckets histograms #16
Conversation
Yah, that is because of https://jira.joyent.us/browse/TOOLS-2400 unfortunately. |
lib/server.js
Outdated
| @@ -153,6 +153,7 @@ function MorayServer(options) { | |||
| help: 'The node-fast CRC compatibilty mode of the Fast server' | |||
| }).set(crc_mode); | |||
|
|
|||
| collector.FIXED_BUCKETS = true; | |||
There was a problem hiding this comment.
@joshwilsdon Is this right? I can't tell from https://github.com/joyent/node-artedi/blob/master/docs/API.md#collectorfixed_buckets nor quickly from a scan of TritonDataCenter/node-artedi#17 how FIXED_BUCKETS is meant to be used.
If it is "always true in node-artedi v2", then is there a point in setting it here?
There was a problem hiding this comment.
node-fast checks for FIXED_BUCKETS here.
There was a problem hiding this comment.
@khalfella Per Josh's comment at #17 (review) I think you are not meant to set this. It is a value that is set by node-artedi automatically.
There was a problem hiding this comment.
I commented on this same issue in #17 but the short answer is: no. It should not be doing this.
There was a problem hiding this comment.
@joshwilsdon - Thanks for making this clearer. I removed the line that sets FIXED_BUCKETS and confirmed that we still get correct histograms.
This small change updates moray to use artedi v2, mainly to make use of fixed buckets histograms introduced in v2. See testing notes in the ticket.
For some reason, I had to update the copyright in
Makefileto 2020 in order formake checkto pass.