Log a error if a potential release build is debuggable (#500)

Signed-off-by: Alex Saveau <[email protected]>
Triple-T · Jan 17, 2019 · 886d480 · 886d480
1 parent 142963c
commit 886d480
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/plugin/src/main/kotlin/com/github/triplet/gradle/play/PlayPublisherPlugin.kt b/plugin/src/main/kotlin/com/github/triplet/gradle/play/PlayPublisherPlugin.kt
@@ -77,8 +77,16 @@ class PlayPublisherPlugin : Plugin<Project> {
         (android as ExtensionAware).extensions.add(PLAY_CONFIGS_PATH, extensionContainer)
         BootstrapOptionsHolder.reset()
         android.applicationVariants.whenObjectAdded {
+            val variantName = name.capitalize()
+
             if (buildType.isDebuggable) {
-                project.logger.info("Skipping debuggable build type ${buildType.name}.")
+                val typeName = buildType.name
+                if (typeName.equals("release", true)) {
+                    project.logger.error(
+                            "GPP cannot configure $variantName because it is debuggable")
+                } else {
+                    project.logger.info("Skipping debuggable build with type '$typeName'")
+                }
                 return@whenObjectAdded
             }
 
@@ -87,7 +95,6 @@ class PlayPublisherPlugin : Plugin<Project> {
             }.singleOrNull().let {
                 it ?: extensionContainer.findByName(buildType.name)
             }.mergeWith(baseExtension)
-            val variantName = name.capitalize()
 
             if (!isSigningReady && !outputsAreSigned) {
                 project.logger.error(