Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8 upgrade #74

Merged
merged 18 commits into from
Dec 27, 2022
Merged

PHP 8 upgrade #74

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
edd4f91
Fix deprecated required params after optional
flashadvocate Dec 23, 2022
affee74
Add docker-compose configuration
flashadvocate Dec 23, 2022
8b5a2f2
Replace string with int
flashadvocate Dec 24, 2022
2811d6a
Fix result must be instanceof mysqli_result
flashadvocate Dec 24, 2022
a21ef31
Remove odd character from account edit
flashadvocate Dec 24, 2022
3c21d0c
Auth instead of realmd
flashadvocate Dec 24, 2022
d769905
Flag bad query in top100
flashadvocate Dec 24, 2022
b5735e5
Fix UNION statement, division by zero
flashadvocate Dec 24, 2022
a2baa4e
Fix HTTP redirect on logout
flashadvocate Dec 24, 2022
797252c
Hide login/register buttons on login page
flashadvocate Dec 24, 2022
2059bf7
Define minimum php level in composer
flashadvocate Dec 24, 2022
6233d3e
Require ext-gmp, ext-mysqli
flashadvocate Dec 24, 2022
a24270a
Replace ternary with max
flashadvocate Dec 24, 2022
b380e82
Gitignore vendor, IDE artifacts
flashadvocate Dec 24, 2022
5df1ff8
Drop Expires header
flashadvocate Dec 24, 2022
5650bc9
Remove invalid Cache-Control directives
flashadvocate Dec 24, 2022
9e967a0
Define viewport defaults
flashadvocate Dec 24, 2022
2068e46
Content-type header charset should default to UTF-8
flashadvocate Dec 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .docker/mysql/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
data/
1 change: 1 addition & 0 deletions top100.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,7 @@ function top100($realmid, &$sqlr, &$sqlc)
<td>'.char_get_level_color($char['level']).'</td>';
if ($type === 'level')
{
// @TODO - fix N+ issue - query inside while loop
$guild_name = $sqlc->result($sqlc->query('SELECT BINARY name AS name FROM guild WHERE guildid = '.$char['gname'].''), 0);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

N+1 query issue here, probably shouldn't be inside the loop. Need to eager load this information elsewhere.

$days = floor(round($char['totaltime'] / 3600)/24);
$hours = round($char['totaltime'] / 3600) - ($days * 24);
Expand Down