Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating package dependencies #476

Conversation

BillSheldon-HunterIndustries
Copy link
Contributor

This PR simply goes through the Package.Json and updates the packages to their latest release. It omits the ngx-bootstrap package as the beta 8 of that package appears to require additional changes beyond updating the dependencies.

MarkPieszak and others added 6 commits November 2, 2017 10:17
…IO#437)

* feat(5.0): update engine-etc for angular 5.0-rc1

WIP - More updates to come

* remove ng 4 references

* update source maps for faster HMR builds

* use aspnetcore-engine & misc updates and fixes

* update to 5.0 official

Closes TrilonIO#434
Closes TrilonIO#435
Closes TrilonIO#430
Closes TrilonIO#424
@schnerring
Copy link

If you want to upgrade to ngx-bootstrap beta 8 you have to change code in the app.module.ts as well. As of beta 8 the Ng2BootstrapModule does no longer exist since it was bad practice anyway and never recommended - it loads all modules from ngx-bootstrap.

Since aspnetcore-angular2-universal only utilizes the accordion module in its ngx-bootstrap demo code you have to change the

import { Ng2BootstrapModule } from "ngx-bootstrap";

bit to

import { AccordionModule } from "ngx-bootstrap/accordion";

In the imports section of app.module.ts you then change Ng2BootstrapModule.forRoot() to AccordionModule.forRoot().

@schnerring
Copy link

Also, @MarkPieszak wouldn't it be good to lock the typescript version to 2.4.2?

Regarding to this comment the officially recommended version of TypeScript by the Angular team is typescript: '>=2.4.2 <2.5'

@MarkPieszak
Copy link
Member

Closing for now as we're still on 4.x at the moment.
Apologies for the mix up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants