-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use matrix strategy for CI/CD #402
Conversation
fix the digests missing tweak dockerhub digests 1 Revert "tweak dockerhub digests 1" This reverts commit 3542125d6035d2330fe1075682b046133568137d. Revert "fix the digests missing" This reverts commit 01954e5687549586233d73339b74e03e2182a339. give this a shot then add short sha fix sha tag names
Getting attestations to work is also going to be...extremely difficult with this setup. If you think they're highly needed, I can keep working away at it, perhaps in another PR. I'm definitely going to need a couple days away from this now that it's working LOL |
Great work! Have some questions:
|
It's in our current builds. I'm assuming it has something to do with
|
1bfbc8b
to
114e780
Compare
From my experience, having SHA as tag for image is quite useless, it's too troublesome for users to pull the image to based on the SHA tag and I haven't done this before. The other reason could be, for example, the image below shows the digest for For the nightly release, we can have that after we merge #327. We can overwrite the digest under nightly tag. And I also find that you are still pushing images to triliumnext/notes, not sure whether you are aware of that. We already have 10 pages of images/tags, but we only have 6 releases now, it's not very reasonable for me. And I think we don't need |
@eliandoran are you okay with removing the
That's because the CI/CD that pushes to DockerHub is using my API key to push to the DockerHub organization, it's not me per-se, it's just my API key. Any development that I'm doing is being pushed to my fork. What you've brought up is outside of the scope for this PR, however. This PR is just to use the matrix strategy. I think it would be better if another PR was opened (or previous merged/closed) that include the suggestions you bring up above. |
I agree I'm a bit overthinking and increasing the scope of this PR. Create an issue to follow up this #412. Otherwise, the changes look good to me. |
I think it would be nice to get rid of the SHA labels, yes. Of course , in a separate PR.
Is there a way to make it appear as if the org is pushing it instead of a particular person? I think that would make it seem more professional. I've done a similar change in the GitHub release process, since we are now releasing directly via GitHub Actions. |
Oh, hopefully I haven't created a conflict then with my changes 😬 |
Run:
https://github.com/perfectra1n/Notes/actions/runs/10757405589
GHCR:


DockerHub:
