Skip to content

Commit

Permalink
build: Investigate not embedding better_sqlite3 natives
Browse files Browse the repository at this point in the history
  • Loading branch information
eliandoran committed Jul 20, 2024
1 parent 956beb1 commit 03ab41b
Show file tree
Hide file tree
Showing 11 changed files with 0 additions and 16 deletions.
Binary file removed bin/better-sqlite3/linux-desktop-better_sqlite3.node
Binary file not shown.
Binary file removed bin/better-sqlite3/linux-server-better_sqlite3.node
Binary file not shown.
Binary file removed bin/better-sqlite3/mac-arm64-better_sqlite3.node
Binary file not shown.
Binary file removed bin/better-sqlite3/mac-x64-better_sqlite3.node
Binary file not shown.
Binary file removed bin/better-sqlite3/win-better_sqlite3.node
Binary file not shown.
3 changes: 0 additions & 3 deletions bin/build-linux-x64.sh
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,6 @@ SRC_DIR=./dist/trilium-linux-x64-src

rm -r "$SRC_DIR"/src/public/app-dist/*.mobile.*

echo "Copying required linux-x64 binaries"
cp -r bin/better-sqlite3/linux-desktop-better_sqlite3.node "$SRC_DIR"/node_modules/better-sqlite3/build/Release/better_sqlite3.node

echo "Packaging linux x64 electron build"
./node_modules/.bin/electron-packager "$SRC_DIR" --asar --out=dist --executable-name=trilium --platform=linux --arch=x64 --overwrite

Expand Down
4 changes: 0 additions & 4 deletions bin/build-mac-arm64.sh
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,6 @@ then
./bin/copy-trilium.sh $SRC_DIR
fi

echo "Copying required mac arm64 binaries"

cp -r bin/better-sqlite3/mac-arm64-better_sqlite3.node $SRC_DIR/node_modules/better-sqlite3/build/Release/better_sqlite3.node

rm -r $SRC_DIR/src/public/app-dist/*.mobile.*

echo "Packaging mac arm64 electron build"
Expand Down
2 changes: 0 additions & 2 deletions bin/build-mac-x64.sh
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@ fi

echo "Copying required mac x64 binaries"

cp -r bin/better-sqlite3/mac-x64-better_sqlite3.node $SRC_DIR/node_modules/better-sqlite3/build/Release/better_sqlite3.node

rm -r $SRC_DIR/src/public/app-dist/*.mobile.*

echo "Packaging mac x64 electron build"
Expand Down
2 changes: 0 additions & 2 deletions bin/build-server.sh
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@ rm -r $PKG_DIR/node_modules/electron*
rm -r $PKG_DIR/webpack*
rm -r $PKG_DIR/electron.js

cp -r bin/better-sqlite3/linux-server-better_sqlite3.node $PKG_DIR/node_modules/better-sqlite3/build/Release/better_sqlite3.node

printf "#!/bin/sh\n./node/bin/node src/www" > $PKG_DIR/trilium.sh
chmod 755 $PKG_DIR/trilium.sh

Expand Down
4 changes: 0 additions & 4 deletions bin/build-win-x64.sh
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,6 @@ then
./bin/copy-trilium.sh $SRC_DIR
fi

echo "Copying required windows binaries"

cp -r bin/better-sqlite3/win-better_sqlite3.node $SRC_DIR/node_modules/better-sqlite3/build/Release/better_sqlite3.node

rm -r $SRC_DIR/src/public/app-dist/*.mobile.*

echo "Packaging windows x64 electron build"
Expand Down
1 change: 0 additions & 1 deletion trilium.iml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
<excludeFolder url="file://$MODULE_DIR$/libraries" />
<excludeFolder url="file://$MODULE_DIR$/libraries" />
<excludeFolder url="file://$MODULE_DIR$/docs" />
<excludeFolder url="file://$MODULE_DIR$/bin/better-sqlite3" />
<excludeFolder url="file://$MODULE_DIR$/data" />
<excludeFolder url="file://$MODULE_DIR$/.flatpak-builder" />
</content>
Expand Down

0 comments on commit 03ab41b

Please sign in to comment.