Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support RE2 #37

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

oprypkhantc
Copy link

Closes #36

Tests now cover both JS's Regex implementation and Google's RE2 (at the very least - Go, but possibly other languages or individual projects as well)

@@ -69,7 +69,8 @@ export const regexes = [
* Ignore Edge with EdgeHTML engine.
*/
{
regex: /Chrom(ium|e)\/(\d+)\.(\d+)(\.(\d+)|)([\d.]+$|.*Safari\/(?![\d.]+ Edge\/[\d.]+$))/,
// Equivalent to /Chrom(ium|e)\/(\d+)\.(\d+)(\.(\d+)|)([\d.]+$|.*Safari\/(?![\d.]+ Edge\/[\d.]+$))/
regex: /Chrom(ium|e)\/(\d+)\.(\d+)(\.(\d+)|)(\.\d+|)([\d.]+$|.*([^e]|[^g]e|[^d]ge|[^E]dge)\/[\d.]+$)/,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
regex: /Chrom(ium|e)\/(\d+)\.(\d+)(\.(\d+)|)(\.\d+|)([\d.]+$|.*([^e]|[^g]e|[^d]ge|[^E]dge)\/[\d.]+$)/,
regex: /Chrom(ium|e)\/(\d+)\.(\d+)(\.(\d+)|)(\.\d+|)($|.*([^e]|[^g]e|[^d]ge|[^E]dge)\/[\d.]+$)/,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid using lookaheads to support PCRE in Caddy/Go
2 participants