Set UTF-8 for all ConfigObj instances #8240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qstokkink
changed the title
qstokkink
force-pushed
the
fix_utf8_dconfig
branch
from
8dd0c28
to
6213050
Compare
qstokkink
changed the title
qstokkink
commented
Nov 1, 2024
Comment on lines
+158
to
+162
| } else if ('error' in response && typeof response.error === 'object') { | ||
| let errorCode = response.error as {handled: boolean, code: string, message: string}; | ||
| setError(`${t("ToastErrorGetMetainfo")} ${errorCode.code}`); | ||
| } else if (isErrorDict(response)) { | ||
| setError(`t("ToastErrorGetMetainfo")} ${response.error}`); | ||
| setError(`${t("ToastErrorGetMetainfo")} ${response.error}`); |
There was a problem hiding this comment.
This is a bit icky, but for the scope of this PR I decided not to make our custom REST API errors consistent with the unhandled errors.
egbertbouman
approved these changes
Nov 1, 2024
qstokkink
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8239
This PR:
SaveAs.tsx.ConfigObjinstances to useutf-8, instead of the defaultascii.Notes:
create_dconfig_from_params#8239 (comment)