Refactor SentryReporter to parse last core output for specific exception types #7727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion types This commit refactors the `SentryReporter` class to parse the "last core output" only for specific exception types. The `send_event` function now checks if the exception type is in a predefined set of types that require parsing. If it is, the last core output is split for better representation in the web view and then parsed using the `parse_last_core_output` function. The resulting core exception is added to the exceptions list, along with some additional modifications to remove unnecessary information. Additionally, a new test case has been added to ensure that the `send_event` function correctly calls `parse_last_core_output` only for specific exception types.
drew2a
force-pushed
the
feature/sentry_parse_specifi_exceptions
branch
from
72b714a
to
0fb2151
Compare
- Refactored the code in `SentryReporter` to handle parsing the last core output. - Removed unnecessary imports and unused variables. - Updated the logic to check if it is necessary to parse the last core output. - Added a new core exception extracted from the last core output, if needed. Fix test_send_last_core_output in test_sentry_reporter.py - Removed unnecessary fields from the event values dictionary in `test_send_last_core_output`. - Updated expected values after refactoring.
kozlovsky
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
SentryReporterclass to parse the "last core output" only for specific exception types. Thesend_eventfunction now checks if the exception type is in a predefined set of types that require parsing. If it is, the last core output is split for better representation in the web view and then parsed using theparse_last_core_outputfunction. The resulting core exception is added to the exceptions list, along with some additional modifications to remove unnecessary information.Additionally, a new test case has been added to ensure that the
send_eventfunction correctly callsparse_last_core_outputonly for specific exception types.It continues the work done in #7722 and makes the logic of #7066 safer.