Fixes #7598: Use safe_repr function to display alert reprs; catch UnicodeDecodeError in all alert handlers #7616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kozlovsky
requested review from
a team and
drew2a
and removed request for
a team
kozlovsky
force-pushed
the
fix/on_tracker_reply_alert_unicode_decode_error
branch
from
31f122e
to
02ee0b5
Compare
drew2a
suggested changes
Oct 2, 2023
| url = alert.url | ||
|
|
||
| if alert.msg: | ||
| status = 'Error: ' + alert.msg |
There was a problem hiding this comment.
I believe this line should be tested since some portions of this function have already been covered by tests.
There was a problem hiding this comment.
I added more tests to cover all branches of this function
drew2a
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #7598. Now the UnicodeDecode error is handled not only in
on_tracker_error_alert, but in all other handlers as well.