Added ability to wait for cache arrival in RequestCache #1327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qstokkink
force-pushed
the
add_rq_wait_for
branch
from
60ea744 to
984e362
Compare
qstokkink
force-pushed
the
add_rq_wait_for
branch
from
984e362 to
69a12a6
Compare
qstokkink
changed the title
egbertbouman
approved these changes
Nov 20, 2024
qstokkink
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1321
This PR:
RequestCache.wait_forto wait for particular caches to be added.test_requestcache.pyto performself.request_cache.shutdown()ontearDown(this is less efficient but it keeps the tests smaller).