tribits_add_option_and_define(): Error out if non-cache vars already defined (trilinos/Trilinos#10355) #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…defined (trilinos/Trilinos#10355) This causes tribits_add_option_and_define(<optionName> <defineName> ...) to error out if <optionName> or <defineName> are already defined as a non-cache vars. This is needed to catch tricky cases that were likely an accident where a package's CMakeLists.txt file was trying to redefine a TriBITS-set project-level non-cache var (e.g. HAVE_ML_SUPERLU in trilinos/Trilinos#11583) which can casue a nasty change in behavior when using the new behvior with CMake 3.21+ with policy CMP0126 where setting cache vars no longer hides local vars. (See Trilinos Issue trilinos/Trilinos#10355 and Trilinos PR trilinos/Trilinos#11583.) NOTE: I also changed this from a macro to a function. There is no reason this needed to be a macro and a function is much safer as all of the local vars created in the funtion will not bleed into the calling scope (only the one's we explicitly set using PARENT_SCOPE). I also added the NOCACHE option for cases where the <defineName> should never be made a global var and should never be exported to other projects. (The NOCACHE option will get used for some non-namespaced vars from the pakages Pliris and Adelus.)
|
@KyleFromKitware, here is a small one to review. Should not take longer than 5 mins |
KyleFromKitware
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the commit message for details and: