Recursive chgrp and chmod for install (#314) #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bartlettroscoe, how are things progressing here. We are still seeing testing failures in our Trilinos sync, so we likely won't deploy for at least another day. |
@jmgate, pretty close. I just overlooked a couple of details that I am now addressing. Should have a Trilinos PR by late morning. |
It does not look like this speeds things up at all so I am disabling for now. But the functionality is there.
…riBITSPub#314, ATDV-241) This is needed to fix some permisisons problems related to that ATDM Trilinos builds (see ATDV-241). See the updated documentation and unit tests for details. Other things I did as part of this: * Options ${PROJECT_NAME}_MAKE_INSTALL_GROUP_READABLE and ${PROJECT_NAME}_MAKE_INSTALL_WORLD_READABLE no longer conditional (since they are enforced by recursive chmod). * Set policy CMP0082 to make install() commands run in order based on how they were executed in the CMake configure. * Added TRIBITS_DIR_IS_BASEDIR() and unit tests * Fixed numerious mispelling of "UNITEST" to "UNITTEST". * Refectored some other installation-cleanup code to by extracting some functions.
bartlettroscoe
force-pushed
the
314-install-set-group-and-permissions
branch
from
0008a98 to
889fa64
Compare
bartlettroscoe
changed the title
|
FYI: This is finally done and I am in the process of pushing with checkin-test.py (and this PR will merge any second). |
|
Thanks @bartlettroscoe. I appreciate all the effort put into it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #314