Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starter for TriBITS Tutorial #192

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Starter for TriBITS Tutorial #192

wants to merge 11 commits into from

Conversation

bartlettroscoe
Copy link
Member

@bartlettroscoe bartlettroscoe commented May 17, 2017

Implements #190.

@bartlettroscoe
Copy link
Member Author

@fryeguy52, are you okay with me merging the commits with the fixes to the Developers Guide and then we can force push a fresh branch for just the addition of a tutorial? I can even create the skeleton if you like and then force push the branch.

Let me know.

fryeguy52 added 7 commits May 19, 2017 09:36
* TribitsTutorialHelloWorld.rst has a nearly complete first draft
of a basic tutorial for TriBITS
* HelloWorldConfigure.output is a file I want to reference in the rst
* generate-tutorial.sh is a copy of the generate-*.py for the
developer's guide and has not been modified at all
Conflicts:
	tribits/doc/developers_guide/TribitsDevelopersGuide.rst
* TribitsTutorialHelloWorld.rst has a nearly complete first draft
of a basic tutorial for TriBITS
* HelloWorldConfigure.output is a file I want to reference in the rst
* generate-tutorial.sh is a copy of the generate-*.py for the
developer's guide and has not been modified at all
@@ -404,7 +404,7 @@ INCLUDE(PrintVar)
#
# If specified, the test command will be assumed to pass if it matches the
# given regular expression. Otherwise, it is assumed to fail. TIPS:
# Replace ';' with '[;]' or CMake will interpretet this as a array eleemnt
# Replace ';' with '[;]' or CMake will interpret this as an array elemnt
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

elemnt should be element

@@ -413,7 +413,7 @@ INCLUDE(PrintVar)
# matches all of the provided regular expressions. Note that this is not
# a capability of raw ctest and represents an extension provided by
# TriBITS. NOTE: It is critical that you replace ';' with '[;]' or CMake
# will interpretet this as a array eleemnt boundary.
# will interpret this as an array elemnt boundary.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

elemnt should be element

@bartlettroscoe
Copy link
Member Author

This got merged a log time ago as of rebased commit 52cec81. Closing this PR (but not #190).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ToDo
Development

Successfully merging this pull request may close these issues.

3 participants