Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prefer parallel hdf5 when using MPI #128

Merged
merged 1 commit into from
Apr 7, 2020
Merged

prefer parallel hdf5 when using MPI #128

merged 1 commit into from
Apr 7, 2020

Conversation

nschloe
Copy link
Contributor

@nschloe nschloe commented Jun 8, 2016

@bartlettroscoe
Copy link
Member

Is this still not resolved? Is this safe to apply?

@gsjaardema, is this the right thing to do for HDF5? I don't have a horse in this race because my configure scripts always just manually set the libraries so I don't rely on the automatic default finds.

@gsjaardema
Copy link
Contributor

This should be ok, but I don't have any experience with it.

I usually build my own HDF5 libraries and explicitly set the HDF5_ROOT to point to the serial or parallel version that I want.

@nschloe
Copy link
Contributor Author

nschloe commented Mar 2, 2017

Using HDF5_ROOT (or HDF5_INCLUDE_DIRS/HDF5_LIBRARY_DIRS) overrides the preference. This PR is just meant to provide a sane default.

Copy link
Member

@bartlettroscoe bartlettroscoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will merge this based on the conversation in #312.

@bartlettroscoe bartlettroscoe merged commit 9856986 into TriBITSPub:master Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants