Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

list sub-command REMOVE_DUPLICATES requires list to be present #30

Closed
lefebvre opened this issue Oct 6, 2014 · 3 comments
Closed

list sub-command REMOVE_DUPLICATES requires list to be present #30

lefebvre opened this issue Oct 6, 2014 · 3 comments

Comments

@lefebvre
Copy link

lefebvre commented Oct 6, 2014

Ross,
I'm getting a configuration error processing some of our packages out of TribitsPackageMacros.cmake

515 LIST(REMOVE_DUPLICATES PARENT_PACKAGE_INCLUDE_DIRS)
516 LIST(REMOVE_DUPLICATES PARENT_PACKAGE_LIBRARY_DIRS)

Processing enabled package: ScaleSys (Shell, Examples)
CMake Error at TriBITS/package_arch/TribitsPackageMacros.cmake:515 (LIST):
list sub-command REMOVE_DUPLICATES requires list to be present.
Call Stack (most recent call first):
TriBITS/package_arch/TribitsPackageMacros.cmake:600 (TRIBITS_PACKAGE_FINALIZE_DEPENDENCY_VARS)
packages/ScaleSys/CMak.eLists.txt:41 (TRIBITS_PACKAGE_POSTPROCESS)

CMake Error at TriBITS/package_arch/TribitsPackageMacros.cmake:516 (LIST):
list sub-command REMOVE_DUPLICATES requires list to be present.
Call Stack (most recent call first):
TriBITS/package_arch/TribitsPackageMacros.cmake:600 (TRIBITS_PACKAGE_FINALIZE_DEPENDENCY_VARS)
packages/ScaleSys/CMakeLists.txt:41 (TRIBITS_PACKAGE_POSTPROCESS)

Any idea?

@bartlettroscoe
Copy link
Member

I am fixing this right now. VUQDemos had the same problem.

@lefebvre
Copy link
Author

lefebvre commented Oct 6, 2014

It appears to happen on packages with only an executable and no libraries

@bartlettroscoe
Copy link
Member

It appears to happen on packages with only an executable and no libraries

I ScaleSys broken up into subpackages? I think that is the only way you would trigger this error.

Those are not packages that VERA uses or even includes. Kevin's sync script removes them from the SCALE snapshot git repo so I can't even see them.

In any case, the fix has been pushed to the TriBITS casl-dev/master repo. Go ahead an pull TriBITS from casl-dev/master and you should be good to go.

I will now merge it into the github/master repo.

@bartlettroscoe bartlettroscoe added this to the 3_in_progress milestone Oct 6, 2014
bartlettroscoe pushed a commit that referenced this issue Oct 7, 2014
…LIBRARY_DIRS (TriBITS #30)

The rare VUQDemos package in CASL VERA has subpackage that don't define any
libraries.

I don't have a test case for this in TriBITS but adding the if guards fixes
this and I do have tests to ensure that duplicates are removed when there are
INCLUDE_DIRS and LIBRARY_DIRS.

Fixes #30

Build/Test Cases Summary
Enabled Packages: TriBITS, COBRA_TF, CTeuchos
0) MPI_DEBUG => passed: passed=293,notpassed=0 (4.57 min)
1) SERIAL_RELEASE => passed: passed=286,notpassed=0 (3.03 min)
Other local commits for this build/test group: e908f96, c51b77e, 3ea1cd3, 08a9c8f, bfa3094, 7bbcc8d, bda695e, 799c6ee, a12526f, 21910be, b5036bf
@bartlettroscoe bartlettroscoe modified the milestones: 3_in_progress, 6_deployed Oct 13, 2014
bartlettroscoe pushed a commit to bartlettroscoe/TriBITS that referenced this issue Dec 3, 2014
…LIBRARY_DIRS (TriBITS TriBITSPub#30)

The rare VUQDemos package in CASL VERA has subpackage that don't define any
libraries.

I don't have a test case for this in TriBITS but adding the if guards fixes
this and I do have tests to ensure that duplicates are removed when there are
INCLUDE_DIRS and LIBRARY_DIRS.

Fixes TriBITSPub#30

Build/Test Cases Summary
Enabled Packages: TriBITS, COBRA_TF, CTeuchos
0) MPI_DEBUG => passed: passed=293,notpassed=0 (4.57 min)
1) SERIAL_RELEASE => passed: passed=286,notpassed=0 (3.03 min)
Other local commits for this build/test group: e908f96, c51b77e, 3ea1cd3, 08a9c8f, bfa3094, 7bbcc8d, bda695e, 799c6ee, a12526f, 21910be, b5036bf
bartlettroscoe pushed a commit to bartlettroscoe/TriBITS that referenced this issue Dec 3, 2014
…LIBRARY_DIRS (TriBITS TriBITSPub#30)

The rare VUQDemos package in CASL VERA has subpackage that don't define any
libraries.

I don't have a test case for this in TriBITS but adding the if guards fixes
this and I do have tests to ensure that duplicates are removed when there are
INCLUDE_DIRS and LIBRARY_DIRS.

Fixes TriBITSPub#30

Build/Test Cases Summary
Enabled Packages: TriBITS, COBRA_TF, CTeuchos
0) MPI_DEBUG => passed: passed=293,notpassed=0 (4.57 min)
1) SERIAL_RELEASE => passed: passed=286,notpassed=0 (3.03 min)
Other local commits for this build/test group: e908f96, c51b77e, 3ea1cd3, 08a9c8f, bfa3094, 7bbcc8d, bda695e, 799c6ee, a12526f, 21910be, b5036bf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants