Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Brazilian Portuguese translations #460

Merged
merged 2 commits into from
Sep 27, 2024
Merged

Conversation

ASVdeM
Copy link
Contributor

@ASVdeM ASVdeM commented Feb 3, 2024

This pull request aims to improve the Brazilian Portuguese translations of trestle, as in its current state, it shows gramatically incorrect messages such as 'Novo Mensagem' and 'O Loja foi deletado com sucesso'.

Thus, it changes the translations to something more neutral, in order to ensure that everything is properly written.

Closes #459

This commit aims to improve the Brazilian Portuguese translations of
trestle, as in its current state, it shows gramatically incorrect
messages such as 'Novo Mensagem' and 'O Loja foi deletado com sucesso'.

Thus, it changes the translations to something more neutral, in order
to ensure that everything is properly written.

failure:
title: "Atenção!"
message: "Falha ao excluir %{model_name}."
message: "O registro de %{model_name} foi deletado com sucesso."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this line be different? This should indicate that a record could not be deleted, but looks to be the same as the successful deletion.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct, this is a wrong translation that says the item was SUCCESSFULLY deleted.

@douglas-vitoriano
Copy link

douglas-vitoriano commented Apr 9, 2024

Hello, I found some grammatical errors in the "config/locales/pt-BR.yml" file. I would like to make corrections if I have permission

config/locales/pt-BR.yml Outdated Show resolved Hide resolved
@spohlenz spohlenz merged commit fd8640e into TrestleAdmin:main Sep 27, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Brazilian Portuguese translation
4 participants