Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(checkbox): Add keyboard handling for Enter and Space keys to tog… #946

Merged
merged 6 commits into from
Nov 13, 2024
Merged

feat(checkbox): Add keyboard handling for Enter and Space keys to tog… #946

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3a22ca0
feat(checkbox): Add keyboard handling for Enter and Space keys to tog…
mryunt02 Oct 18, 2024
e88e3bc
Merge branch 'next' into feature/checkbox/keyboard-toggle
mryunt02 Oct 18, 2024
5c88b9f
Merge branch 'next' into feature/checkbox/keyboard-toggle
mryunt02 Oct 21, 2024
ac74036
feat(checkbox): Enter key removed for checkbox
mryunt02 Oct 30, 2024
b4657c5
Merge branch 'next' into feature/checkbox/keyboard-toggle
buseselvi Nov 13, 2024
6fa092a
Merge branch 'next' into feature/checkbox/keyboard-toggle
erbilnas Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/components/checkbox-group/checkbox/bl-checkbox.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,13 @@ export default class BlCheckbox extends FormControlMixin(LitElement) {
private handleFieldValueChange = (event: CustomEvent<Array<string>>) => {
this.checked = event.detail.includes(this.value);
};
private handleKeyDown(event: KeyboardEvent) {
if (event.code === "Space") {
this.checked = !this.checked;
this.onChange(this.checked);
event.preventDefault();
}
}

render(): TemplateResult {
let icon = "";
Expand Down Expand Up @@ -206,6 +213,7 @@ export default class BlCheckbox extends FormControlMixin(LitElement) {
aria-readonly=${this.disabled}
.indeterminate=${this.indeterminate}
@change=${this.handleChange}
@keydown=${this.handleKeyDown}
value=${ifDefined(this.value)}
@blur=${this.blur}
/>
Expand Down
Loading