4609: Fix duplicate and copy / paste behavior for linked grous. #4613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier to write test expectations.
When pasting a linked group with ID x, we want the following benavior: - if no groups with ID x exist, the pasted group keep its ID - if one group with ID x exists, the pasted group gets a new ID - if more than one group with ID x exists, the pasted group keeps its ID When pasting more than one group with the same ID x, we want them to remain mutually linked in all cases.
This function makes it easier to extract children of nodes without exactly knowing their position.
We want duplicate and copy / paste to behave the same in most situations, so we extend the tests for duplicateObjects to cover copy / paste as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4609. With this PR, we fix the behavior of duplicate and copy / paste wrt. linked groups, and we unify the behavior as well so that it makes no difference if the user duplicates or copy / pastes objects (unless they modify the map in between copying and pasting nodes.