Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix vulnerabilities #15

Merged
merged 2 commits into from
May 10, 2022
Merged

fix vulnerabilities #15

merged 2 commits into from
May 10, 2022

Conversation

jennypypy
Copy link

@jennypypy jennypypy commented May 9, 2022

I want to recompile and redeploy rwd_labels_compile_service to get the new labels for Enosis, there are some vulnerabilities about minimist and async , so I need to update l10ns to fix these vulnerabilities.
image
image

I updated [email protected] to update minimist to ^1.2.5, updated [email protected] to fix async vulnerability, then used npm audit fix --legacy-peer-deps to update minimist to 1.2.6 to fix minimist vulnerability. see details in the below image
image

Then I want to verify if l10ns works well after these changes, but I can not use npm run test locally
image

I asked elevenbeans to help verify, he found some errors when running npm run test and these errors also be found in the master branch.

I have no ideas about these and want to fix vulnerabilities quickly, @denkrasnov Could you help have a look?

yurist38
yurist38 previously approved these changes May 9, 2022
Copy link

@yurist38 yurist38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks legit 👍🏻

denkrasnov
denkrasnov previously approved these changes May 10, 2022
@jennypypy jennypypy dismissed stale reviews from denkrasnov and yurist38 via 17fadd5 May 10, 2022 12:03
@jennypypy jennypypy merged commit a3e1742 into master May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants