Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove dbg! from library code #25

Merged
merged 1 commit into from
Apr 14, 2023
Merged

remove dbg! from library code #25

merged 1 commit into from
Apr 14, 2023

Conversation

rosaliedewinther
Copy link
Contributor

No description provided.

@MarijnS95
Copy link
Member

Checked, no more dbg remaining (nor printlns).

@rosaliedewinther rosaliedewinther merged commit 8d0ab01 into main Apr 14, 2023
@rosaliedewinther rosaliedewinther deleted the remove-dbg branch April 14, 2023 09:12
@Jasper-Bekkers
Copy link
Member

Should we enable the clippy that checks for this / enable our set of clippy lints for this repo?

@MarijnS95
Copy link
Member

@Jasper-Bekkers perhaps, yes! I still have EmbarkStudios/rust-ecosystem#59 (comment) in my unprocessed-notifications-backlog pertaining a [lints] configuration without hacking it up via rustflags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarijnS95 MarijnS95 MarijnS95 approved these changes

@Jasper-Bekkers Jasper-Bekkers Awaiting requested review from Jasper-Bekkers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rosaliedewinther @MarijnS95 @Jasper-Bekkers