Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model config tests #627

Open
wants to merge 15 commits into
base: dev
Choose a base branch
from

Conversation

curt-tigges
Copy link
Contributor

Description

Added a test to verify that all model configs currently listed in loading_from_pretrained are not None.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Screenshots

Please attach before and after screenshots of the change if applicable.

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have not rewritten tests relating to key interfaces which would affect backward compatibility

@bryce13950
Copy link
Collaborator

The failure is due to these tests now triggering http requests on gated models. GitHub does allow for two buckets of variables, and we could put the hf token into the variables section to make this work, but that would involve also allowing access to secrets, which is not possible. It seems like a lot of people are requesting this sort of functionality though, so maybe a solution will come up later https://github.com/orgs/community/discussions/44322. The other solution would be to manually drop on the config for these models, which is very feasible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants