New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(aside): add optional tooltip on header #1014

Closed

nguyenlam123 wants to merge 1 commit into Tradeshift:master from nguyenlam123:tooltip-on-aside

Contributor

nguyenlam123 commented Oct 14, 2021 •

edited

Loading

Provide an opt-in tooltip on the header of the aside component.
Can be added to the html via data-ts.tooltip property, for example:

<aside data-ts="Aside"
  id="aside-with-tooltip"
  data-ts.title="Aside Title with tooltip"
  data-ts.tooltip="My Tooltip">
  <div data-ts="Panel">
    <p>Aside content.</p>
  </div>
</aside>

Can be added programatically as displayed below

ts.ui.get('#myAside', function(aside) {
  aside.open();
  aside.tooltip('tooltip');
});

, provided that the user has previously added an aside component with the id called myAside.

Tooltip appearance can be displayed in the gif below


          feat(aside): add optional tooltip on header

28caba1

nguyenlam123 requested a review from a team as a code owner

October 14, 2021 17:48

Contributor Author

nguyenlam123 commented Oct 15, 2021

Closed in favor of #1015

nguyenlam123 closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet