build: replace 'string' package dependency with custom function to check is a file ends with '.html' or not #1008
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the package
grunt-spiritual-edbml-tmpfix
hijackingString.prototype
with non-standard polyfills it is impossible to use a standardString.prototype.endsWith()
function, so I had to implement the custom one-line function to check is the filename ends with.html
or not.What's wrong with the custom implementation in
grunt-spiritual-edbml-tmpfix
? It looks like this:The problems are:
You can see the implementation of
String.prototype.endsWith
ingrunt-spiritual-edbml-tmpfix
here: https://unpkg.com/[email protected]/tasks/things/compiler.js