New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Updated docs generator code to use changed API of cheerio library #1007

Merged

aleks-elkin merged 1 commit into master from elkin/fix-docs-processor

Jul 29, 2021

Contributor

aleks-elkin commented Jul 28, 2021

After upgrade of Cheerio library from 0.22.0 to 1.0.0-rc.10 in the PR #1001 our docs generator stop working, at least in local dev mode.

One of the issues was empty script blocks, which actually was a breaking change in cheerio: Doing .text() of a <script> brings empty string on 1.0.0-rc.2 cheeriojs/cheerio#1050
Another one I did not find the root cause, but after upgrade our placeholder for navigation tabs start added to the html <body> instead of <head>. To fix this I added a manual appendTo("head") for these blocks which is solved the issue.


          build: Updated docs generator code to use changed API of cheerio library

574a1a7

aleks-elkin requested a review from a team as a code owner

July 28, 2021 19:59

Kian-Esmaeilpour approved these changes

View reviewed changes

aleks-elkin merged commit 306d534 into master

aleks-elkin deleted the elkin/fix-docs-processor branch

July 29, 2021 07:59

aleks-elkin mentioned this pull request

Release 12.8.0 #1020

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet