-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BDD MLE, modular compilation, alg. data types, M1 compatibility #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nearly all of the LOC changed are due to added examples. To see how the backend changed, start with the explanations of includes at the bottom of
src/inference/inference.jl
.BDD MLE
See
examples/qc/tour_2_learning.jl
.Modular compilation
The separation of WMC, BDD compilation, and pr supports BDD MLE. For an example that provides more general motivation, see the following function, which efficiently finds the exact max value of a DistUInt:
Algebraic data types
See
src/dist/inductive/list.jl
for an example definition of an algebraic datatypes andtest/dist/inductive/list_test.jl
for its usage.M1 compatibility
I ripped out TikzGraphs and TikzPictures (which depend on Tectonic, see this issue), and added a pointer to
rtjoa/CUDD.jl:m1compat
in the README.