Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(integrations): Add Tracecat prefix to email #828

Merged
merged 6 commits into from
Feb 10, 2025

Conversation

bouddha-fr
Copy link
Contributor

No description provided.

Copy link

zeropath-ai bot commented Feb 5, 2025

No security or compliance issues detected. Reviewed everything up to 17cb31e.

Security Overview
  • 🔎 Scanned files: 1 changed file(s)
Detected Code Changes
Change Type Relevant files
Configuration changes ► docker-compose.ollama.yml
    Add new Ollama service configuration
► docker-compose.yml
    Update image versions and remove Ollama config
► pyproject.toml
    Update dependencies
Refactor ► registry/tracecat_registry/_internal/registry.py
    Modify secrets handling
► registry/tracecat_registry/base/core/email.py
    Add sender prefix functionality
► tracecat/dsl/scheduler.py
    Simplify task scheduling logic
Other ► docs/**/*.mdx
    Update documentation and version references

Reply to this PR with @zeropath-ai followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

Copy link
Contributor

@topher-lo topher-lo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Spoke too soon. Do we really need this change? Can you confirm it's not possible to add a prefix to the sender already?

@topher-lo topher-lo added the enhancement New feature or request label Feb 5, 2025
@topher-lo topher-lo changed the title hotfix(email):email tracecat-sender feat(integrations): Add Tracecat prefix to email Feb 5, 2025
Copy link
Contributor

@topher-lo topher-lo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@topher-lo
Copy link
Contributor

Nice PR @bouddha-fr !

@topher-lo topher-lo merged commit 70406f0 into TracecatHQ:main Feb 10, 2025
1 check passed
topher-lo added a commit that referenced this pull request Feb 10, 2025
@bouddha-fr bouddha-fr deleted the hotfix/email-tracecat-sender branch February 10, 2025 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants