Add optional sanitizer build configurations #185
Conversation
Detecting data races and memory issues in unsafe code can be difficult and time consuming. To aid with this, add an optional nightly toolchain which exposes experimental `-Zsanitizer` flags. This lets us run builds and test with `--config=asan` and `--config=tsan` to enable AddressSanitizer and ThreadSanitizer. These sanitizers incur heavy performance penalties and shouldn't be enabled in production builds. We can't enable these in CI yet, since ref_store_test fails under asan and all runtime tests fail under tsan. The changed rust files fix issues that trigger nightly clippy.
There was a problem hiding this comment.
@allada @chrisstaite-menlo FYI this doesn't enable MemorySanitizer because that would require everything to be sanitized (including C++ dependendcies). It does't enable LeakSanitizer because leak detection on amd64 is already enabled via asan and standalone lsan appears to be bugged and requires additional workarounds (rust-lang/rust#111073).
Reviewable status: 0 of 4 files reviewed, all discussions resolved
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @aaronmondal)
There was a problem hiding this comment.
Reviewable status:
Detecting data races and memory issues in unsafe code can be difficult and time consuming.
To aid with this, add an optional nightly toolchain which exposes experimental
-Zsanitizerflags. This lets us run builds and test with--config=asanand--config=tsanto enable AddressSanitizer and ThreadSanitizer. These sanitizers incur heavy performance penalties and shouldn't be enabled in production builds.We can't enable these in CI yet, since ref_store_test fails under asan and all runtime tests fail under tsan.
The changed rust files fix issues that trigger nightly clippy.
This change is